New issue
Advanced search Search tips

Issue 869576 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox changing css position of live region causes failure

Project Member Reported by leberly@chromium.org, Jul 31

Issue description

Google Chrome	69.0.3497.14 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

Steps to reproduce: 
# Turn on ChromeVox with ctrl + alt + z 
# Navigate to  https://minorninth.github.io/aria-live-region-tests/live_region_tests.html
# Navigate to <button>just changing the css position should not announce anything</button> and press Enter to invoke it
Expected: success message or "This is an alert" message is just read
Actual: ChromeVox says the following:
"Alert This is an alert. Alert This is an alert. Live region space Live region s region Live region failed. Live region failed."
It then repeats the second part of this message several times, Live region s and Live region failed. 
 
This reproduced 2/3 times, not sure what caused it to pass during that one instance. 
Please let me know if this should be split into another bug, but I see a similar failure on the same test page when invoking "set textContent in inner paragraph". It says Alert several times, then alert successful several times, then alert failed many more times. It also reads previous alerts from hangouts chat. 
Cc: aleventhal@chromium.org
This failure also happens on "<button>two live region changes, one second apart</button>"

Given the intermittent nature of this bug, I'll await further direction from the devs for next steps on how to repro. 
Thanks. It'd be helpful to know if this is a recent regression - maybe try it on stable?


Can you clarify what happens with "two live region changes, one second apart"? What's the expected vs actual?

Google Chrome	69.0.3497.21 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

First, I'll clarify the expected and actual in M69 for "two live region changes, one second apart"

# Turn on ChromeVox with ctrl + alt + z 
# Navigate to  https://minorninth.github.io/aria-live-region-tests/live_region_tests.html
# Navigate to "<button>two live region changes, one second apart</button>"
# Invoke it with Enter.
Expected, two parts: First, this text will be interrupted by the second utterance before it finishes: 
"This utterance should be interrupted before it finishes"
Then, part two, ChromeVox will say "Live region succeeded"

Actual: 
ChromeVox says one after another "This utterance should be interrupted before it finishes" and then "Live region succeeded." The second one did not interrupt the first as expected. 

However, when I did this I didn't repro the behavior where ChromeVox says extraneous content. 
I split the above bug into its own bug, 870881 to avoid it becoming a distraction. Now, to go back to the intermittent ChromeVox adding extraneous content to the live region speech: 

Google Chrome	69.0.3497.21 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

Let's narrow this down to the first bug at hand:

# Turn on ChromeVox with ctrl + alt + z 
# Navigate to  https://minorninth.github.io/aria-live-region-tests/live_region_tests.html
# Navigate to <button>just changing the css position should not announce anything</button> and press Enter to invoke it
Expected: success message or "This is an alert" message is just read
Actual: This time, ChromeVox says the following:
"You are online. Alert This is an alert. Alert This is an alert. Live region space Live region s region Live region failed. Live region failed."
It then repeats the second part of this message several times, Live region s and Live region failed.  
And now for stable:

Google Chrome	67.0.3396.99 (Official Build) (64-bit)
Firmware Version	Google_Eve.9584.107.0
# Turn on ChromeVox with ctrl + alt + z 
# Navigate to  https://minorninth.github.io/aria-live-region-tests/live_region_tests.html
# Navigate to <button>just changing the css position should not announce anything</button> and press Enter to invoke it
Expected: success message visually shown or "This is an alert" message is just read
Actual: behaves as expected 3/3 times. 

And Beta for good measure:

Does not repro in Stable, does repro in Beta. 

Google Chrome	68.0.3440.87 (Official Build) beta (64-bit)
Firmware Version	Google_Eve.9584.151.0

# Turn on ChromeVox with ctrl + alt + z 
# Navigate to  https://minorninth.github.io/aria-live-region-tests/live_region_tests.html
# Navigate to <button>just changing the css position should not announce anything</button> and press Enter to invoke it
Expected: success message visually shown or "This is an alert" message is just read
Actual: produces error where extraneous content is read after second attempt. 
Labels: -Pri-1 Pri-2
I do have a fix here:
https://chromium-review.googlesource.com/c/chromium/src/+/1162930

Note that the test page does have a few live regions on load, so you'll hear all of the random live regions when you refresh or when you first load the page.

Labels: M69A11yTests
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5669e8d7f690e4540f8e4447ce0949f3b793ffc0

commit 5669e8d7f690e4540f8e4447ce0949f3b793ffc0
Author: David Tseng <dtseng@chromium.org>
Date: Fri Aug 10 01:07:53 2018

Fix live region filter to allow subtree update end

Bug:  842874 , 869576 
Change-Id: I2cf585a3763a5685c39d30d7f7b35b232e2ed9bf
Reviewed-on: https://chromium-review.googlesource.com/1162930
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581996}
[modify] https://crrev.com/5669e8d7f690e4540f8e4447ce0949f3b793ffc0/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js
[modify] https://crrev.com/5669e8d7f690e4540f8e4447ce0949f3b793ffc0/chrome/renderer/extensions/automation_ax_tree_wrapper.cc
[modify] https://crrev.com/5669e8d7f690e4540f8e4447ce0949f3b793ffc0/chrome/renderer/extensions/automation_ax_tree_wrapper.h
[modify] https://crrev.com/5669e8d7f690e4540f8e4447ce0949f3b793ffc0/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/5669e8d7f690e4540f8e4447ce0949f3b793ffc0/chrome/renderer/extensions/automation_internal_custom_bindings.h
[modify] https://crrev.com/5669e8d7f690e4540f8e4447ce0949f3b793ffc0/chrome/renderer/resources/extensions/automation_custom_bindings.js
[modify] https://crrev.com/5669e8d7f690e4540f8e4447ce0949f3b793ffc0/chrome/test/data/extensions/api_test/automation/tests/tabs/tree_change.js

Status: Fixed (was: Available)
Fixed this reproduction. Note that you will hear the various live regions on load -- I think this is a page error and not one in ChromeVox. Circle back w/ dmazzoni@ for this one.

Sign in to add a comment