New issue
Advanced search Search tips

Issue 869573 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

android_platform_backend.AndroidPlatformBackend has both IsApplicationRunning and IsAppRunning

Project Member Reported by nednguyen@chromium.org, Jul 31

Issue description

This is very confusing & we should fix this.
 
Looks like platform.IsAppRunning is not used anywhere so we should delete that one.

Also IsApplicationRunning appears to be used only by tests :-/ wondering if we need this at all?
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/226b95461af217fea1b626bc1fd6b0a2de9228c2

commit 226b95461af217fea1b626bc1fd6b0a2de9228c2
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Wed Aug 01 13:34:08 2018

[telemetry] Remove android_platform_backend.IsAppRunning

The backend also has a IsApplicationRunning method for doing the
exact same thing; and this one is not used.

Bug: chromium:869573
Change-Id: Id2ce19d30610573bcabbec8061c8a0ad0300db89
Reviewed-on: https://chromium-review.googlesource.com/1158504
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/226b95461af217fea1b626bc1fd6b0a2de9228c2/telemetry/telemetry/internal/platform/android_platform_backend.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0910944bfe3e6bbfc8a350fa16e4859c3b4bcfc

commit f0910944bfe3e6bbfc8a350fa16e4859c3b4bcfc
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Aug 01 15:19:36 2018

Roll src/third_party/catapult 68afb50705f8..226b95461af2 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/68afb50705f8..226b95461af2


git log 68afb50705f8..226b95461af2 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 perezju@chromium.org [telemetry] Remove android_platform_backend.IsAppRunning


Created with:
  gclient setdep -r src/third_party/catapult@226b95461af2

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:869573
TBR=sullivan@chromium.org

Change-Id: I1522430003ba65bb5b8a8755d6fd19d067b45467
Reviewed-on: https://chromium-review.googlesource.com/1158326
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579809}
[modify] https://crrev.com/f0910944bfe3e6bbfc8a350fa16e4859c3b4bcfc/DEPS

So one of the two methods is now gone. But, as I noted in #1, the other one is also never used (other that tests).

Do you think we do need this method? Or should just be removed as well?

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment