Issue metadata
Sign in to add a comment
|
Context menus have control-key shortcuts in alerts |
||||||||||||||||||
Issue descriptionVersion 70.0.3508.0 (Official Build) canary (64-bit) Repro: 1. Show an alert (http://avidrissman.github.io/htmltests/delay.html is useful) 2. Right-click on the text of the alert Expected: A normal Mac-like context menu Actual: A Mac-implemented context menu with two items, both of which have control-key shortcuts
,
Aug 1
I suppose that dropping shortcuts in the Views-based menus would be the quickest way to fix this.
,
Aug 1
Those are Cocoa menus, though. The Views menus should retain their accelerators since they are used for the app menu.
,
Aug 1
Absolutely. On the Mac, the context menus (no matter if implemented via Cocoa or Views menus) should have no shortcuts.
,
Aug 1
Actually I'm not sure I was agreeing with you in comment 3. What I think is that on the Mac and on the Mac only, no matter what implementation of menus, context menus should not have shortcuts. It's not an issue of Cocoa vs Views menus, but of context vs non-context menus.
,
Aug 8
The NextAction date has arrived: 2018-08-08
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c50480db92fe1220814910400ace4683a4d438a commit 3c50480db92fe1220814910400ace4683a4d438a Author: Avi Drissman <avi@chromium.org> Date: Fri Aug 10 22:42:44 2018 Never show shortcuts in contextual menus on the Mac. This is platform convention. BUG= 869564 TEST=as in bug Change-Id: I3a4dbec12c5047219f255694eb4251405422e8fe Reviewed-on: https://chromium-review.googlesource.com/1164307 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582363} [modify] https://crrev.com/3c50480db92fe1220814910400ace4683a4d438a/ui/base/cocoa/menu_controller.mm
,
Aug 10
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by rsesek@chromium.org
, Jul 31