New issue
Advanced search Search tips

Issue 869554 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Printing this html file as PDF uses 4+ gb of memory

Reported by spoon...@gmail.com, Jul 31

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.75 Safari/537.36

Steps to reproduce the problem:
1. Open markup.html (~330 pages of barcodes)
2. Open print dialog (cmd+p)
3. Observe memory usage while generating pdf print preview

What is the expected behavior?
Memory usage should stay low/reasonable. 

What went wrong?
Memory usage grows to 4+ gb

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 68.0.3440.75  Channel: stable
OS Version: OS X 10.14.0
Flash Version: 

Noticed this while using electron's .printToPDF() feature, but can reproduce it using the normal print dialog in chrome.
 
markup.html
4.5 MB View Download
Components: Internals>Printing
Components: Blink>Paint
Labels: -Type-Bug OS-Chrome OS-Linux OS-Windows Type-Bug-Regression
Owner: chrishtr@chromium.org
Status: Untriaged (was: Unconfirmed)
This bisected to r482854. Before, the renderer would take ~450 MB of RAM. Now it takes gigabytes. When testing, I usually stopped when I see the renderer cross 1 GB in top. The built-in task manager does not seem to always get accurate results when the renderer is busy.
Labels: -Type-Bug-Regression Type-Bug
Status: Assigned (was: Untriaged)
Sorry, but I can't help saying that Electron being so far behind causes this to not really be a regression for tracking purposes, since it was broken so many versions ago.
Owner: masonfreed@chromium.org
@mason, here is a simple, real bug to fix.

https://chromium-review.googlesource.com/c/chromium/src/+/544024 changed
transforms to cause an "infinite cull rect" when painting inside. This is
necessary during the normal flow of operations, but during printing,
I think we can still apply the transform.

The code has evolved somewhat since the patch referenced above.
The proper fix would be to make use_infinite_dirty_rect return false here:

https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_layer_painter.cc?type=cs&q=AdjustForPaintProperties&sq=package:chromium&g=0&l=238

as long as GraphicsContext::IsPrinting is true.
The reason why I think it's ok to apply the cull rect for printing is that
when we print, paint data structures are invalidated before and after the operation, because printing is a totally different mode of painting.
Ok I'll take a look!
Cc: pdr@chromium.org wangxianzhu@chromium.org
Ok, changing use_infinite_dirty_rect to false when printing does seem to fix THIS issue - memory goes from >7GB to about 200MB additional upon printing. Here's the in-progress CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1175320

However, it causes two real layout test failures, on tests created by wangxianzhu in this CL:
  https://chromium-review.googlesource.com/c/chromium/src/+/1045560
And I believe it is related to this TODO added there: TODO(wangxianzhu): Make this function fragment aware. The issue (I think) is that the first fragment (page 1?) is correctly rendered, but subsequent fragments miss the floating transformed elements.

I'm going to continue debugging this, but wanted to add this comment in case I'm way off base.
The tests fail without use_infinite_dirty_rect because we fail to adjust the cull rect for the different PaintOffsetTranslations (and/or other transforms) in different fragments. PaintLayerPainter::AdjustForPaintProperties() adjusts the cull rect for the first fragment only, assuming that all fragments of the layer have the same transform state.

https://chromium-review.googlesource.com/c/chromium/src/+/1090009 (abandoned) is a way to fix the issue but is less clean than making AdjustForPaintProperties() fragment aware. The comments in the CL may still be helpful for understanding the issue.
Thanks @wangxianzhu, I appreciate the help. I read through your discussion with @chrishtr on that CL, and from your comments, it would appear that making AdjustForPaintProperties fragment-aware might be larger than I could comfortably manage at this point. Would you agree? I will certainly give it a try, if it's something you think I could pull off with <1 week's exposure to the codebase.
Cc: masonfreed@chromium.org
Owner: wangxianzhu@chromium.org
I'm taking this bug and will reopen https://chromium-review.googlesource.com/c/chromium/src/+/1090009 for the fix.
Ok thanks!
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f57056b2ce47b0a0a46e460cb74b36e92fb129

commit 29f57056b2ce47b0a0a46e460cb74b36e92fb129
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Sep 18 23:41:39 2018

[PE] Fix repeating fixed-position with PaintOffsetTranslation

Previously PaintLayerPainter and PaintLayerClipper assumed that all
fragments of an object share the same transform state. This is not true
for repeating fixed-position objects with PaintOffsetTranslation: The
fragments have different PaintOffsetTranslations. Previously we use
infinite clip rect to avoid the problem of incorrect cull rects for
repeated fragments. However, that also caused we painted too much for
each page because of the infinite cull rects, causing slow printing
and too much memory usage.

Changed the following places to calculate correct cull rects for
repeating fixed-position objects:
1. PaintLayerFragment now saves root_fragment_data to indicate its
   coordinate space;
2. PaintLayerPainter::AdjustForPaintProperties() no longer uses
   infinite cull rect when printing;
3. In PaintLayerPainter before painting the LayoutObject,
   cull_rect is adjusted from the border box space of
   |fragment.root_fragment_data| to the containing transform's space;
4. In PaintLayer::CollectFragments(), for each fragment, the input
   dirty rect is adjusted to the current root fragment's border box
   space;
5. PaintLayerClipper::CalculateRectsWithGeometryMapper() is simplified
   to just map using transform states.

Bug:  848839 , 869554 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6d86e3716e91dbe5422cbf5e58b99fa2282d94dd
Reviewed-on: https://chromium-review.googlesource.com/1090009
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592261}
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/compositing/massive-scale-interest-rect-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/compositing/overflow/scaled-overflow-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/compositing/visibility/visibility-composited-transforms-expected.png
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/compositing/visibility/visibility-composited-transforms-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/fast/frames/frame-set-rotation-hit-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/fast/frames/frame-set-scaling-centered-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/fast/frames/frame-set-scaling-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/fast/frames/frame-set-scaling-rotate-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/fast/frames/frame-set-scaling-skew-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/layer-due-to-layer-children-deep-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/scaled-mask-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/css3/blending/background-blend-mode-overlapping-accelerated-elements-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/media/video-layer-crash-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/svg/hixie/mixed/011-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/svg-css-transforms-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-foreignObject-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-hixie-mixed-008-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-hixie-mixed-009-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/2d/compound-transforms-vs-containers-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/svg-vs-css-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/transforms/transformed-focused-text-input-expected.txt
[delete] https://crrev.com/c341db6c8ccdd6c77c0d61f6379272bb6046ebe5/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scaled-mask-expected.png
[delete] https://crrev.com/c341db6c8ccdd6c77c0d61f6379272bb6046ebe5/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scaled-mask-expected.txt
[delete] https://crrev.com/c341db6c8ccdd6c77c0d61f6379272bb6046ebe5/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/mask-with-filter-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/scaled-mask-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-overlapping-accelerated-elements-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/media/video-layer-crash-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/svg/hixie/mixed/011-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/svg/transforms/svg-css-transforms-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/2d/compound-transforms-vs-containers-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/svg-vs-css-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/transforms/transformed-focused-text-input-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/mask-with-filter-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/scaled-mask-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/css3/blending/background-blend-mode-overlapping-accelerated-elements-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/media/video-layer-crash-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/svg/hixie/mixed/011-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/svg/transforms/svg-css-transforms-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-foreignObject-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/2d/compound-transforms-vs-containers-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/svg-vs-css-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/transforms/transformed-focused-text-input-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[add] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/printing/fixed-positioned-composited-expected.html
[add] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/printing/fixed-positioned-composited.html
[add] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/printing/fixed-positioned-overflow-scroll-expected.html
[add] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/printing/fixed-positioned-overflow-scroll.html
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/WebKit/LayoutTests/svg/zoom/page/zoom-foreign-content-expected.txt
[delete] https://crrev.com/c341db6c8ccdd6c77c0d61f6379272bb6046ebe5/third_party/WebKit/LayoutTests/virtual/threaded/compositing/visibility/visibility-composited-transforms-expected.txt
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/core/paint/fragment_data.cc
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/core/paint/fragment_data.h
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/core/paint/paint_layer_clipper.cc
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/core/paint/paint_layer_fragment.h
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/core/paint/paint_layer_painter.h
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/platform/graphics/paint/geometry_mapper.cc
[modify] https://crrev.com/29f57056b2ce47b0a0a46e460cb74b36e92fb129/third_party/blink/renderer/platform/graphics/paint/geometry_mapper.h

Status: Fixed (was: Assigned)
How do I know what version of Chrome this will go out in? I'm still seeing issues as of 69.0.3497.106 since I'm using Electron, and the latest build used is a few versions old.

Thanks!
The "Find Releases" section on https://omahaproxy.appspot.com will tell you 29f57056b2ce47b0a0a46e460cb74b36e92fb129 initially landed in 71.0.3556.0.

Sign in to add a comment