26cb34c1-c134-4353-917c-d43d769e750f |
||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@google.com 26cb34c1-c134-4353-917c-d43d769e750f Builders failed on: - Android Nexus5 Perf: https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5%20Perf
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/44d40fafd2330a14e482b83ce942a574bf012f88 commit 44d40fafd2330a14e482b83ce942a574bf012f88 Author: Nghia Nguyen <nednguyen@google.com> Date: Tue Jul 31 21:38:43 2018 Improve error message of unhandleable error Bug: chromium:869548 Change-Id: I37cf18bb81da55704c26a3e5f23a9a12fc284ad5 R=crouleau@chromium.org, johnchen@chromium.org TBR=perezju@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1157226 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/44d40fafd2330a14e482b83ce942a574bf012f88/telemetry/telemetry/internal/story_runner.py
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bf136214445b8018d40cc60ea12ad9e80c8cd53 commit 0bf136214445b8018d40cc60ea12ad9e80c8cd53 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jul 31 23:31:48 2018 Roll src/third_party/catapult 100f0ee2ceb7..44d40fafd233 (3 commits) https://chromium.googlesource.com/catapult.git/+log/100f0ee2ceb7..44d40fafd233 git log 100f0ee2ceb7..44d40fafd233 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 nednguyen@google.com Improve error message of unhandleable error 2018-07-31 sadrul@chromium.org Reland "rendering: Add pipeline metrics." 2018-07-31 dtu@chromium.org [pinpoint] Don't wrap quest name in status box header. Created with: gclient setdep -r src/third_party/catapult@44d40fafd233 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:869548 ,chromium:855328, chromium:868648 TBR=sullivan@chromium.org Change-Id: If13c6ea7fc05a6ae309af1c0de781fc9e558af60 Reviewed-on: https://chromium-review.googlesource.com/1156917 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579619} [modify] https://crrev.com/0bf136214445b8018d40cc60ea12ad9e80c8cd53/DEPS
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/68afb50705f8f2cdc5d352c568490832ae72aa5d commit 68afb50705f8f2cdc5d352c568490832ae72aa5d Author: Nghia Nguyen <nednguyen@google.com> Date: Wed Aug 01 01:27:46 2018 Update AndroidBrowserBackend.IsBrowserRunning for consistency In the attached bug, we found a problem with browser.Close() raising exception and causing inconsistent state on Android. The reason is that in browser.Close(), we first check browser.IsBrowserRunning, the log out browser.pid to warn about browser is still alive after close. However, for some reason, the check browser_backend.IsBrowserRunning was returning True but invoking browser_backend.pid raising an exception with browser already being closed and no browser pid can be found. This CL fixes the problem by changing android_browser_backend.IsBrowserRunning() to rely on querying the number of browser processes can be found which is also used by browser_backend.pid implementation. Bug: chromium:869548 Change-Id: If898d5d526bbb240f895dccad1bfbfbd35644a42 TBR=perezju@chromium.org Change-Id: If898d5d526bbb240f895dccad1bfbfbd35644a42 Reviewed-on: https://chromium-review.googlesource.com/1157236 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/68afb50705f8f2cdc5d352c568490832ae72aa5d/telemetry/telemetry/internal/backends/browser_backend_unittest.py [modify] https://crrev.com/68afb50705f8f2cdc5d352c568490832ae72aa5d/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8b35f103834f43a85fd5a14af1f3cef977c498d commit e8b35f103834f43a85fd5a14af1f3cef977c498d Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Aug 01 04:26:38 2018 Roll src/third_party/catapult 5c2d9e757a6f..68afb50705f8 (2 commits) https://chromium.googlesource.com/catapult.git/+log/5c2d9e757a6f..68afb50705f8 git log 5c2d9e757a6f..68afb50705f8 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 nednguyen@google.com Update AndroidBrowserBackend.IsBrowserRunning for consistency 2018-08-01 skau@chromium.org Update link to Benchmark Policy. Created with: gclient setdep -r src/third_party/catapult@68afb50705f8 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:869548 , chromium:869698 TBR=sullivan@chromium.org Change-Id: Ia7268312cf54098e1a868f0d07bc4b6fdaee22d0 Reviewed-on: https://chromium-review.googlesource.com/1157884 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579700} [modify] https://crrev.com/e8b35f103834f43a85fd5a14af1f3cef977c498d/DEPS
,
Aug 1
Just FYI, there is still a race condition in the code: the browser could stop running between the call to IsBrowserRunning() and browser.pid.
,
Aug 1
We no longer see massive number of unexpected skips in https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5%20Perf/2148 I think this is fixed. #7: I think that's true but it would be very rare, and not consistent like the failure in this bug.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nednguyen@chromium.org
, Jul 31Components: Speed>Telemetry Speed>Benchmarks>Waterfall