DocumentProvider: Add a server-controlled session backoff flag. |
|||||||
Issue descriptionThe remote API will be able to inform the client that the drive corpus for the calling user is unlikely to provide useful results and we can back off. Very nice to have but not absolutely critical for M69. Eventually it would be nice to store this value as setting for a week+, but a browser session gives most of the benefit for the least amount of risk.
,
Aug 7
A line of this is needed for merging 869687.
,
Aug 8
Rationale: A line of this CL will be needed for a later merge; discussed yesterday and treating as two separate merges was decided vs landing both changes in the same bug. This feature is behind a finch flag and will be used in beta and at 1% in stable to look at traffic patterns. The rest of this CL reduces traffic to a server, which is useful but not critical.
,
Aug 8
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 8
Pls apply appropriate OSs label. Thank you.
,
Aug 8
apologies for omission. Desktop Chrome.
,
Aug 8
No worries at all, thank you. Approving merge to M69 branch 3497 based on comment #3. skare@ will request another merge to M69 when ready.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4c24d24723e9012e973b51e9c60c16086865929 commit e4c24d24723e9012e973b51e9c60c16086865929 Author: Travis Skare <skare@chromium.org> Date: Wed Aug 08 21:04:00 2018 [omnibox] [DocumentProvider] Add parsing of a new server-sent backoff flag. Bug: 869513 Change-Id: Idd1db8f01eb27cb5b5cfdc063ee23b0dc09feb15 Reviewed-on: https://chromium-review.googlesource.com/1157167 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580283}(cherry picked from commit 8a4b7b15e802b5ff54aa433c19ef9fda760b06e9) Reviewed-on: https://chromium-review.googlesource.com/1167862 Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#510} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/e4c24d24723e9012e973b51e9c60c16086865929/components/omnibox/browser/document_provider.cc [modify] https://crrev.com/e4c24d24723e9012e973b51e9c60c16086865929/components/omnibox/browser/document_provider.h [modify] https://crrev.com/e4c24d24723e9012e973b51e9c60c16086865929/components/omnibox/browser/document_provider_unittest.cc
,
Aug 8
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 2