New issue
Advanced search Search tips

Issue 869501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ClientRoot needs to set insets on top-levels

Project Member Reported by sky@chromium.org, Jul 31

Issue description

ClientRoot creates a ClientSurfaceEmbedder. The insets parameter supplied to ClientSurfaceEmbedder should be the insets to the client-area.
 
Labels: -Pri-3 Proj-Mash-SingleProcess Pri-2
This likely impacts guttering.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c5c5e83bf92c74a3ceab27dcff30619743448ca

commit 5c5c5e83bf92c74a3ceab27dcff30619743448ca
Author: Scott Violet <sky@chromium.org>
Date: Mon Oct 01 22:33:25 2018

window-service: propagates client-area-insets to ClientSurfaceEmbedder

The client area insets of a top-level need to be propagated to the
ClientSurfaceEmbedder.

BUG= 869501 
TEST=covered by tests

Change-Id: Id5aca98e46d596e8e43c7ea71150f59a0db638da
Reviewed-on: https://chromium-review.googlesource.com/1252145
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595604}
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/BUILD.gn
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/client_root.cc
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/client_root.h
[add] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/client_root_test_helper.cc
[add] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/client_root_test_helper.h
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/server_window.cc
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/server_window_unittest.cc
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/window_tree.cc
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/services/ws/window_tree.h
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/ui/aura/mus/client_surface_embedder.cc
[modify] https://crrev.com/5c5c5e83bf92c74a3ceab27dcff30619743448ca/ui/aura/mus/client_surface_embedder.h

Status: Fixed (was: Started)

Sign in to add a comment