New issue
Advanced search Search tips

Issue 869492 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 873358



Sign in to add a comment

Implement Feature Policy: lazyload

Project Member Reported by ekaramad@chromium.org, Jul 31

Issue description

This is the tracking bug for the implementation of 'lazyload' policy. This policy will be used to change the default or given value of 'lazyload' attribute through the use of feature policy.


Link to WICG/github issue:https://github.com/WICG/feature-policy/issues/193

Link to explainer: TBA.

Link to chromestatus report: https://www.chromestatus.com/feature/5641405942726656
 
Labels: -Type-Launch Type-Feature
Blockedon: 873358
Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8d86dd35e7fea2975e1ad193368570fd6bd8e73

commit d8d86dd35e7fea2975e1ad193368570fd6bd8e73
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Wed Sep 12 15:28:03 2018

Implement Feature-Policy: lazyload

This CL implements the 'lazyload' policy which acts in place of the
lazyload attribute for nested frames and enforces lazyloading regardless
of the value of 'lazyload' attribute.

A follow up CL will implement the feature for images (after
LazyImageLoading is implemented).

Bug:  869492 
Change-Id: I2f8ab7ad9a5937636f270c84563c73ad392dbb01
Reviewed-on: https://chromium-review.googlesource.com/1171374
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590688}
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-disabled-tentative.sub.html
[add] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-disabled-tentative.sub.html.headers
[add] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-enabled-tentative.sub.html
[add] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-enabled-tentative.sub.html.headers
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/common.js
[add] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/lazyload-contents.html
[add] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/WebKit/LayoutTests/virtual/lazyload-policy/external/wpt/feature-policy/experimental-features/lazyload/README.txt
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/blink/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/blink/public/mojom/feature_policy/feature_policy.mojom
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/d8d86dd35e7fea2975e1ad193368570fd6bd8e73/third_party/blink/renderer/platform/feature_policy/feature_policy.cc

Cc: iclell...@chromium.org
Status: Fixed (was: Assigned)
Marking the bug as fixed (implemented behind flag).
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03b4fcd98e2647b8560c90b7f650a7f57cff96da

commit 03b4fcd98e2647b8560c90b7f650a7f57cff96da
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Fri Oct 12 14:32:17 2018

Apply 'lazyload' feature policy for images

In CL 1171374 'lazyload' feature policy was introduced as a new
policy-controlled feature which would modify (restrict) the usage of the
lazyload attribute. The implementation only applied the feature to frame
owner elements. This CL extends the policy's coverage to images as well.

Bug:  869492 
Change-Id: I9a2bd309ac366b75308b657d3ea129a7717ad23f
Reviewed-on: https://chromium-review.googlesource.com/c/1251024
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599204}
[modify] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-disabled-image-tentative.sub.html
[add] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-disabled-image-tentative.sub.html.headers
[add] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-enabled-image-tentative.sub.html
[add] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-image-attribute-on-sanity-check-tentative.sub.html
[modify] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/common.js
[add] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/lazyload.png
[modify] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/blink/renderer/core/html/html_image_element.cc
[modify] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
[modify] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/blink/renderer/core/html/parser/html_preload_scanner.h
[modify] https://crrev.com/03b4fcd98e2647b8560c90b7f650a7f57cff96da/third_party/blink/renderer/core/loader/image_loader.cc

Sign in to add a comment