Expected behavior: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/869481/Expected_vid.MOV?_ga=2.228225685.-967102564.1532641052

Actual behavior: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/869481/Actual_vid.MOV?_ga=2.228225685.-967102564.1532641052

omrilio@ - This sounds like a Launcher bug? Is there someone on the team who can take a look?

Release blockers should be P1 or P0

I have the exact same version and cannot reproduce the bug. Can you please check again?

I am still able to repro the issue. Tested on eve, kevin, peppy with different user accounts

Tested on latest M69 build 10895.19.0, 69.0.3497.33

I'm able to reproduce this issue for Downloads folder as well. Unable to open the files of Downloads & Drive folders from Launcher search result.
Tested on M69 build 10895.19.0, 69.0.3497.33 on nautilus.

Hi Luciano,

Did a bisect on this and it came out to this CL:

https://chromium-review.googlesource.com/c/chromium/src/+/1130559

Could you please investigate this further?

I'll check this today, thanks.

Found the issue and the fix is out for review.

Fix: crrev.com/c/1186006
Tests: crrev.com/c/1186295

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1441a75447e7e60b160916ea28d7795f730576c2

commit 1441a75447e7e60b160916ea28d7795f730576c2
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Aug 24 05:18:16 2018

Fix opening file from Launcher search

The IF condition is inverted, it should return when it isn't a native
FileEntry/DirectoryEntry, only FilesAppEntry's types have "type_name"
attribute defined.

Test: New browser test being added on crrev.com/c/1186295
Bug:  869481 
Change-Id: Icfdbdedc8289c65447f02c0604e6a36ac8176e6b
Reviewed-on: https://chromium-review.googlesource.com/1186006
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585698}
[modify] https://crrev.com/1441a75447e7e60b160916ea28d7795f730576c2/ui/file_manager/file_manager/background/js/launcher_search.js
[modify] https://crrev.com/1441a75447e7e60b160916ea28d7795f730576c2/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/1441a75447e7e60b160916ea28d7795f730576c2/ui/file_manager/file_manager/foreground/js/file_tasks.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8678da2a4bc31a3e5a273a20b745ea60e05880d8

commit 8678da2a4bc31a3e5a273a20b745ea60e05880d8
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Aug 24 05:23:12 2018

Add tests for opening file from Launcher search

Add new test file for tests related to Launcher.

Add test util to call the Files app event listener that listens to
chrome.launcherSearchProvider.OnOpenResult event, which emulates a
call from the Launcher app.

Bug:  869481 
Change-Id: I178b20a8860348d613dd655291747a98e94cce95
Reviewed-on: https://chromium-review.googlesource.com/1186295
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585699}
[modify] https://crrev.com/8678da2a4bc31a3e5a273a20b745ea60e05880d8/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/8678da2a4bc31a3e5a273a20b745ea60e05880d8/ui/file_manager/file_manager/background/js/test_util_base.js
[add] https://crrev.com/8678da2a4bc31a3e5a273a20b745ea60e05880d8/ui/file_manager/integration_tests/file_manager/launcher_search.js
[modify] https://crrev.com/8678da2a4bc31a3e5a273a20b745ea60e05880d8/ui/file_manager/integration_tests/file_manager_test_manifest.json

Requesting merge of crrev.com/c/1186006

I've tested the fix by creating a new branch from branch-heads/3497, patched the cl and manually tested the issue which is working.

This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Merge of #18 approved, M69.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2806df0b2c01350a441ffdb35d82293cf3575b0a

commit 2806df0b2c01350a441ffdb35d82293cf3575b0a
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Aug 31 05:34:23 2018

Fix opening file from Launcher search

The IF condition is inverted, it should return when it isn't a native
FileEntry/DirectoryEntry, only FilesAppEntry's types have "type_name"
attribute defined.

Test: New browser test being added on crrev.com/c/1186295
Bug:  869481 
Change-Id: Icfdbdedc8289c65447f02c0604e6a36ac8176e6b
Reviewed-on: https://chromium-review.googlesource.com/1186006
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#585698}(cherry picked from commit 1441a75447e7e60b160916ea28d7795f730576c2)
Reviewed-on: https://chromium-review.googlesource.com/1198710
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#858}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2806df0b2c01350a441ffdb35d82293cf3575b0a/ui/file_manager/file_manager/background/js/launcher_search.js
[modify] https://crrev.com/2806df0b2c01350a441ffdb35d82293cf3575b0a/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/2806df0b2c01350a441ffdb35d82293cf3575b0a/ui/file_manager/file_manager/foreground/js/file_tasks.js

Verified on ChromeOS 10895.49.0, 69.0.3497.87 beta-channel