New issue
Advanced search Search tips

Issue 869470 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 869818
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"external/wpt/background-fetch/get.https.window.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 31

Issue description

"external/wpt/background-fetch/get.https.window.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNleHRlcm5hbC93cHQvYmFja2dyb3VuZC1mZXRjaC9nZXQuaHR0cHMud2luZG93Lmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: peter@chromium.org
Status: Assigned (was: Untriaged)
This is failing with the following in the log:
06:21:42.803 15161 worker/2 external/wpt/background-fetch/get.https.window.html crashed, (stderr lines):
06:21:42.803 15161   
06:21:42.803 15161   DevTools listening on ws://127.0.0.1:41209/devtools/browser/539d68f2-994f-480d-ae6d-eb43d645a7b0
06:21:42.803 15161   [15302:15309:0731/062142.640747:FATAL:background_fetch_scheduler.cc(30)] Check failed: finished_callback_. 
06:21:42.803 15161   #0 0x000003d048bc base::debug::StackTrace::StackTrace()
06:21:42.803 15161   #1 0x000003c62ffb logging::LogMessage::~LogMessage()
06:21:42.803 15161   #2 0x000003291df9 content::BackgroundFetchScheduler::Controller::Finish()
06:21:42.803 15161   #3 0x00000328ecd2 content::BackgroundFetchJobController::Abort()
06:21:42.803 15161   #4 0x00000328002b content::BackgroundFetchContext::AbandonFetches()
06:21:42.803 15161   #5 0x0000032806d8 content::BackgroundFetchContext::OnRegistrationDeleted()
06:21:42.803 15161   #6 0x0000034c2cd6 base::ObserverListThreadSafe<>::NotifyWrapper()
06:21:42.803 15161   #7 0x000001eed2ad _ZN4base8internal7InvokerINS0_9BindStateIMN5media29GpuMemoryBufferVideoFramePool8PoolImplEFvPNS5_14FrameResourcesERKN3gpu9SyncTokenEEJ13scoped_refptrIS5_ES7_S9_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
06:21:42.803 15161   #8 0x000003c6c67d base::debug::TaskAnnotator::RunTask()
06:21:42.803 15161   #9 0x000003c6b5f6 base::MessageLoop::RunTask()
06:21:42.803 15161   #10 0x000003c6bb02 base::MessageLoop::DoWork()
06:21:42.803 15161   #11 0x000003d23609 base::MessagePumpLibevent::Run()
06:21:42.803 15161   #12 0x000003c6afc1 base::MessageLoop::Run()
06:21:42.803 15161   #13 0x000003c8f2d6 base::RunLoop::Run()
06:21:42.803 15161   #14 0x000003cd5e8a base::Thread::Run()
06:21:42.803 15161   #15 0x0000032f1684 content::BrowserProcessSubThread::IOThreadRun()
06:21:42.803 15161   #16 0x0000032f15cf content::BrowserProcessSubThread::Run()
06:21:42.803 15161   #17 0x000003cd6217 base::Thread::ThreadMain()
06:21:42.803 15161   #18 0x000003d16cbf base::(anonymous namespace)::ThreadFunc()
06:21:42.803 15161   #19 0x7f21d4cb5184 start_thread
06:21:42.803 15161   #20 0x7f21d049303d clone

Going by git log and the timing of the flakes, I am suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1152969
peter@ PTAL
Labels: -Sheriff-Chromium
Revert is going through CQ, removing sheriff-chromium label.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79033eac809eff69ae9fec73e218b48e7e9f9bef

commit 79033eac809eff69ae9fec73e218b48e7e9f9bef
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Jul 31 19:21:29 2018

Disable external/wpt/background-fetch/get.https.window.html

This layout test has been flaky for some time.

TBR=peter@chromium.org

Bug:  869470 
Change-Id: I1749a81e5172962126c0ee32afaeb7f78e4fca13
Reviewed-on: https://chromium-review.googlesource.com/1157118
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579519}
[modify] https://crrev.com/79033eac809eff69ae9fec73e218b48e7e9f9bef/third_party/WebKit/LayoutTests/TestExpectations

Cc: peter@chromium.org
Issue 869818 has been merged into this issue.
This test is flaky on site_per_process_webkit_layout_tests too.
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/156050
Components: Blink>BackgroundFetch
 Issue 869920  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d46730192ef03a7c6c4dba59c221220d67c143bd

commit d46730192ef03a7c6c4dba59c221220d67c143bd
Author: Peter Beverloo <peter@chromium.org>
Date: Tue Aug 07 15:20:38 2018

Disable a bunch of Background Fetch WPT bots

There's a crash in our implementation that surfaces on the bots every
now and then, so let's not block the commit queue while we investigate.

Bug:  869470 
Change-Id: Id81493f7540537651d8b13fbe3d5a84dd7721013
Reviewed-on: https://chromium-review.googlesource.com/1165239
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581229}
[modify] https://crrev.com/d46730192ef03a7c6c4dba59c221220d67c143bd/third_party/WebKit/LayoutTests/TestExpectations

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "external/wpt/background-fetch/get-ids.https.window.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdleHRlcm5hbC93cHQvYmFja2dyb3VuZC1mZXRjaC9nZXQtaWRzLmh0dHBzLndpbmRvdy5odG1sDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/167a1685c3314ac1acf6ee4e759272bca54839b7

commit 167a1685c3314ac1acf6ee4e759272bca54839b7
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Wed Aug 08 04:55:28 2018

Disable Layout test flaky fail, timeout, crash

TBR=futhark@chromium.org

Bug:  869470 ,871105,872025, 871416 
Change-Id: Iab76b2330c889d36243f95f3c105f9bba7568819
Reviewed-on: https://chromium-review.googlesource.com/1166564
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581476}
[modify] https://crrev.com/167a1685c3314ac1acf6ee4e759272bca54839b7/third_party/WebKit/LayoutTests/TestExpectations

Mergedinto: 869818
Status: Duplicate (was: Assigned)
Reversing the duping of this bug (since Issue 869818 is more general; it isn't just get that's flaky).

Sign in to add a comment