New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869457 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Don't return cards from Google Account as part of basic-card

Project Member Reported by rouslan@chromium.org, Jul 31

Issue description

Don't return cards from Google Account as part of basic-card.

https://blog.chromium.org/2018/07/bringing-google-pay-to-paymentrequest.html
 
Labels: OS-iOS
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7db21f130aa7cfd0c49722feb8c6c7fae515c75

commit f7db21f130aa7cfd0c49722feb8c6c7fae515c75
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Aug 14 16:38:27 2018

No Google account cards in basic-card.

Don't return cards from Google account as part of basic-card.
https://blog.chromium.org/2018/07/bringing-google-pay-to-paymentrequest.html

Bug:  869457 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If6129689aad77c33d5bc8cff1e819cbacc386778
Reviewed-on: https://chromium-review.googlesource.com/1165316
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582939}
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDebitTest.java
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDontHaveDebitTest.java
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteServerCardTest.java
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndBasicCardWithModifiersTest.java
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServerCardTest.java
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/chrome/browser/ui/views/payments/modifiers_browsertest.cc
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/chrome/browser/ui/views/payments/payment_request_debit_browsertest.cc
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/components/payments/core/features.cc
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm
[modify] https://crrev.com/f7db21f130aa7cfd0c49722feb8c6c7fae515c75/ios/chrome/browser/ui/payments/payment_request_modifiers_egtest.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Below are the steps used to verify this bug:
1.Sign in to Chrome.
2.Go to Payments.google.com , and make sure a payment method is added in there.
3.Now to to  Chrome Settings ->Payment Methods .Make sure credit cards are added in there(locally).
4.Go to https://madmath.github.io/samples/paymentrequest/dynamic-shipping/ and tap Buy.
Expected :
User does not see any Credit Cards that are linked with your google payments.

Verified on iPhone XSMAX iOS 12, iPad Pro 12'9 iOS 11.4.1 on build 70.0.3538.40 Beta
Looks good.

Sign in to add a comment