New issue
Advanced search Search tips

Issue 869448 link

Starred by 1 user
Status: Fixed
Owner:
pbos@chromium.org
Closed: Aug 15
Cc:
grt@chromium.org
cyan@chromium.org
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

text does not always fit into the update chrome bubble

Project Member Reported by wfh@chromium.org, Jul 31 
Chrome Version: 70.0.3504.0
OS: Windows 10

What steps will reproduce the problem?
(1) Come back to PC
(2)
(3)

What is the expected result?

Text fits in box

What happens instead?

Text does not fix.



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Histogram: UI.DeviceScale recorded 1 samples (flags = 0x41)
100  ------------------------------------------------------------------------O (1 = 100.0%)

I think this is to do with the text updating.
chrome-update-available.png
10.5 KB View Download

Comment 1 by grt@chromium.org, Aug 1 

bsep: it looks like BubbleFrameView::UpdateWindowTitle() does a layout after setting the title. do we need to do something else to enlarge the bubble as a whole if the title suddenly gets taller?

Comment 2 by xialinyan@google.com, Aug 1

Owner: cyan@chromium.org

Comment 3 by cyan@chromium.org, Aug 13

Owner: pbos@chromium.org

Comment 4 by pbos@chromium.org, Aug 14

Cc: tapted@chromium.org cyan@chromium.org
::Layout inside BubbleFrameView doesn't push the bounds of the widget containing it. I don't know if there's a good heuristic for when to do that or not. Calling PreferredSizeChanged() in BubbleFrameView sure wasn't enough to trigger it.

I have a band-aid fix up here: crrev.com/c/1173664 as I think this bubble is safe to resize as the title refreshes, doing so in the BubbleFrameView general case seems scary to me.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39c55f86fc12b240b860e3d9bfb14034e0e78e07

commit 39c55f86fc12b240b860e3d9bfb14034e0e78e07
Author: Peter Boström <pbos@chromium.org>
Date: Wed Aug 15 23:15:16 2018

Resize relaunch bubble on title changes

This fixes a bug where the browser window is left open and the dialog
title rolls over from "A Chromium update is available" to "A Chromium
update has been available for N days" which causes the title to wrap.

This is only a band-aid fix, calling BubbleFrameView::UpdateWindowTitle
should either push the width or height of the dialog to accommodate for
the longer title string.

Bug:  chromium:869448 
Change-Id: Ib78082e386111cb1da3835952fb9644051c6e572
Reviewed-on: https://chromium-review.googlesource.com/1173664
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583435}
[modify] https://crrev.com/39c55f86fc12b240b860e3d9bfb14034e0e78e07/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc
[modify] https://crrev.com/39c55f86fc12b240b860e3d9bfb14034e0e78e07/chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.cc
[modify] https://crrev.com/39c55f86fc12b240b860e3d9bfb14034e0e78e07/chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.h

Comment 6 by pbos@chromium.org, Aug 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment