Remove RemoveAllSurfaceReferences |
|||
Issue descriptionRemoveAllSurfaceReferences removes a |surface| from the parent list of its children and the child list of its parents. This is not necessary. - We can just stop tracking the parents and this would eliminate the need to update the parent list of the children. - Since |surface| is getting destroyed, its parents are getting destroyed too. The child list of the parents will get cleared when they're destroyed.
,
Jul 31
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/426325e519c0035e43789e6ef0b16616cf094d7e commit 426325e519c0035e43789e6ef0b16616cf094d7e Author: akaba <akaba@google.com> Date: Thu Aug 02 21:04:23 2018 Remove Child to Parent relationship in SurfaceReference This CL removes Child to Parent relationship is in SurfaceReference as a cleanup step toward making Viz more clean and efficient. This relationship is not contributing to any logic so it's safe to be removed. Bug: 868925 , 869444 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I458ca17de868ef31eada09b5ff23c09c13c22523 Reviewed-on: https://chromium-review.googlesource.com/1155095 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Saman Sami <samans@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580316} [modify] https://crrev.com/426325e519c0035e43789e6ef0b16616cf094d7e/components/viz/service/frame_sinks/surface_references_unittest.cc [modify] https://crrev.com/426325e519c0035e43789e6ef0b16616cf094d7e/components/viz/service/surfaces/surface_manager.cc [modify] https://crrev.com/426325e519c0035e43789e6ef0b16616cf094d7e/components/viz/service/surfaces/surface_manager.h
,
Aug 2
Close?
,
Aug 2
|
|||
►
Sign in to add a comment |
|||
Comment 1 by samans@chromium.org
, Jul 31