New issue
Advanced search Search tips

Issue 869429 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

snapped ARC window doesn't use immersive frame in tablet mode

Project Member Reported by osh...@chromium.org, Jul 31

Issue description

It's regression in chrome caption.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68e0e1a99883a5558130a99402394e0cb38e62b4

commit 68e0e1a99883a5558130a99402394e0cb38e62b4
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Aug 02 00:22:40 2018

Enable autohide frame in Snapped ClientControlledShellSurface

Bug:  869429 
Test: covered by unittest
Change-Id: I192d74e0dd467238af2bf0db7e7e37b5df69ed81
Reviewed-on: https://chromium-review.googlesource.com/1156881
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580007}
[modify] https://crrev.com/68e0e1a99883a5558130a99402394e0cb38e62b4/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/68e0e1a99883a5558130a99402394e0cb38e62b4/components/exo/client_controlled_shell_surface_unittest.cc

Labels: Merge-Rejected-69
Labels: -Merge-Rejected-69 Merge-Request-69
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 7

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/365435acb6277450bd565ae6b86c5ba3fc220026

commit 365435acb6277450bd565ae6b86c5ba3fc220026
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Aug 10 21:50:07 2018

Enable autohide frame in Snapped ClientControlledShellSurface

Bug:  869429 
Test: covered by unittest
Change-Id: I192d74e0dd467238af2bf0db7e7e37b5df69ed81
Reviewed-on: https://chromium-review.googlesource.com/1156881
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580007}(cherry picked from commit 68e0e1a99883a5558130a99402394e0cb38e62b4)
Reviewed-on: https://chromium-review.googlesource.com/1171429
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#547}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/365435acb6277450bd565ae6b86c5ba3fc220026/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/365435acb6277450bd565ae6b86c5ba3fc220026/components/exo/client_controlled_shell_surface_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment