Add equivalent of SigninManager::Observer::GoogleSigninFailed() to IdentityManager::Observer |
||||||||
Issue descriptionGoogleSigninFailed is part of SigninManagerBase::Observer https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_manager_base.h?rcl=f553d1ef9f2e9dd6a1d5e2cae7ea214b5263d58b&l=60 This issue tracks need evaluating need-for and implementing same on IdentityManager.
,
Aug 3
This will be needed by several clients, e.g., SigninTracker.
,
Aug 15
Sorry, didn't get to this one. Issue 866518 and its dependencies took longer than expected.
,
Sep 5
,
Oct 3
,
Oct 3
I'm working on this as it's blocking bug 809539
,
Oct 4
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fad05a9735f2e7efd786392ba9c729b773a15476 commit fad05a9735f2e7efd786392ba9c729b773a15476 Author: Sergio Villar Senin <svillar@igalia.com> Date: Thu Oct 04 16:24:29 2018 Add SigninManager's GoogleSigninFailed() equivalent to IdentityManager IdentityManager::Observer now provides OnPrimaryAccountSigninFailed() offering the same functionality than the SigninManager equivalent API. Bug: 869418 Change-Id: I00d42b622a483bb9b763aaf04d10e4f639e39042 Reviewed-on: https://chromium-review.googlesource.com/c/1257835 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#596699} [modify] https://crrev.com/fad05a9735f2e7efd786392ba9c729b773a15476/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/fad05a9735f2e7efd786392ba9c729b773a15476/services/identity/public/cpp/identity_manager.h [modify] https://crrev.com/fad05a9735f2e7efd786392ba9c729b773a15476/services/identity/public/cpp/identity_manager_unittest.cc
,
Oct 4
Should be fixed now |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by blundell@chromium.org
, Aug 2