The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b3946376dda4cb31e75d06b842fd9f03ebecd6

commit f9b3946376dda4cb31e75d06b842fd9f03ebecd6
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Jul 31 16:37:26 2018

cros: Disable views login by default

This CL is targeting only for m69.

Bug:  869411 
Change-Id: Ie0cf9c8eb0f98b53ac3e7c4fda5585185ce95b9c
Reviewed-on: https://chromium-review.googlesource.com/1156875
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579432}
[modify] https://crrev.com/f9b3946376dda4cb31e75d06b842fd9f03ebecd6/ash/public/cpp/ash_features.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b754952bdb68f8f91692b405f47e8f55b52b9a

commit e3b754952bdb68f8f91692b405f47e8f55b52b9a
Author: Jacob Dufault <jdufault@chromium.org>
Date: Tue Jul 31 17:18:41 2018

Revert "cros: Disable views login by default"

This reverts commit f9b3946376dda4cb31e75d06b842fd9f03ebecd6.

Reason for revert: Not meant for m70

Original change's description:
> cros: Disable views login by default
> 
> This CL is targeting only for m69.
> 
> Bug:  869411 
> Change-Id: Ie0cf9c8eb0f98b53ac3e7c4fda5585185ce95b9c
> Reviewed-on: https://chromium-review.googlesource.com/1156875
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579432}

TBR=xiyuan@chromium.org,jdufault@chromium.org

Change-Id: I09b0cb12eb8d6c1e66cc7081fe66009e90be4a92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  869411 
Reviewed-on: https://chromium-review.googlesource.com/1156926
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579448}
[modify] https://crrev.com/e3b754952bdb68f8f91692b405f47e8f55b52b9a/ash/public/cpp/ash_features.cc

Merge request for f9b3946376dda4cb31e75d06b842fd9f03ebecd6, which was reverted because it was not intended to land on m70.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge for M69.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a10eba9ab63c0dea47271753cad664ab959c2e2

commit 6a10eba9ab63c0dea47271753cad664ab959c2e2
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Aug 01 23:37:39 2018

cros: Disable views login by default

This CL is targeting only for m69.

TBR=jdufault@google.com

(cherry picked from commit f9b3946376dda4cb31e75d06b842fd9f03ebecd6)

Bug:  869411 
Change-Id: Ie0cf9c8eb0f98b53ac3e7c4fda5585185ce95b9c
Reviewed-on: https://chromium-review.googlesource.com/1156875
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579432}
Reviewed-on: https://chromium-review.googlesource.com/1159530
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#324}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/6a10eba9ab63c0dea47271753cad664ab959c2e2/ash/public/cpp/ash_features.cc

Hi Jacob,
Could you please cc cros-perf-detectives@google.com when you next time disable/enable views login?

We as ChromeOS performance team are monitoring performance of tests (go/crosboltv2) and noticed login time went up and down (issue 850363 and issue 873092). It would save us time to triage/bisect regressions if you could inform us potential big performance changes.

Thanks.

BTW, nice work, the new views login is so fast!

No plans to disable again, but will do. Sorry for the triage/bisects - I'm happy that infra can catch the delta though :)