New issue
Advanced search Search tips

Issue 869400 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2
Cc:
kariahda@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Crash when enabling InProduct help

Project Member Reported by gambard@chromium.org, Jul 31 
With UI Refresh flag disabled.

What steps will reproduce the problem?
(1) Enable InProductHelp to IPH_BottomToolbarTip or IPH_LongPressToolbarTip
(2) Open an NTP
(3) Kill and relaunch the app

What is the expected result?
Nothing should be displayed.

What happens instead?
App crashes.

The config might be enabled for non-UI refresh user, we need to make sure it is also working for them.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a4e730478ad8103e52f85466d7b8a21c391e94d

commit 3a4e730478ad8103e52f85466d7b8a21c391e94d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Aug 01 19:48:37 2018

Fix bubble presentation for non-UI refresh

The bubble presentation of UI Refresh tips in non-UI Refresh app should
be a no-op.

Bug:  869400 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I308c2a5dee2088af8b6ca56567a7089944f8bf34
Reviewed-on: https://chromium-review.googlesource.com/1156694
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579904}
[modify] https://crrev.com/3a4e730478ad8103e52f85466d7b8a21c391e94d/ios/chrome/browser/ui/bubble/bubble_presenter.mm

Comment 2 by gambard@chromium.org, Aug 2

Cc: kariahda@chromium.org
Status: Verified (was: Started)
Verified on Canary.
+kariahda@ for merge approval.

Comment 3 by marq@chromium.org, Aug 2

Labels: Merge-Request-69

Comment 4 by kariahda@chromium.org, Aug 2

Labels: -Merge-Request-69 Merge-Approved-69
Approved.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ecd2449e268b61e0d5794d379161b24b1e16dba

commit 9ecd2449e268b61e0d5794d379161b24b1e16dba
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Aug 02 18:18:15 2018

Fix bubble presentation for non-UI refresh

The bubble presentation of UI Refresh tips in non-UI Refresh app should
be a no-op.

Bug:  869400 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I308c2a5dee2088af8b6ca56567a7089944f8bf34
Reviewed-on: https://chromium-review.googlesource.com/1156694
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579904}(cherry picked from commit 3a4e730478ad8103e52f85466d7b8a21c391e94d)
Reviewed-on: https://chromium-review.googlesource.com/1160982
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#344}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/9ecd2449e268b61e0d5794d379161b24b1e16dba/ios/chrome/browser/ui/bubble/bubble_presenter.mm

Comment 6 by vbhatso...@chromium.org, Aug 8 

Verified in build 69.0.3497.31 Beta on iPhoneX iOS 11.4, iPhone 7+ iOS 10.3.3, iPad Pro 12'9 iOS 11.4 With UI Refresh flag disabled.
►

Sign in to add a comment