Issue metadata
Sign in to add a comment
|
URL form location bar is incorrectly read with VoiceOver |
||||||||||||||||||||||||
Issue descriptionApp Version: 70.0.3508.0 canary iOS Version: 11.4.1, 12 beta#5, 10.3.3 Device: iPhone6s, iPhoneX, iPad Pro URL: any Enable VoiceOver form iOS Settings > General > Accessibility > Voice Over > ON Steps to reproduce: 1. Launch Google Chrome Canary 2. Navigate to any webpage (say google.com) 3. Tap on the omnibox Observed results: VoiceOver reads as "Address and Search bar, Search or Type URL" button Expected results: Should read the current URL displayed inside the omnibox. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M69 Yes Bug reproducible on the current beta channel build (App Version, iOS Version): M68 NO
,
Aug 1
,
Aug 1
,
Aug 7
,
Aug 7
Issue 533452 has been merged into this issue.
,
Aug 9
,
Aug 9
Issue 685818 has been merged into this issue.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6 commit 89c85f7cc4b4cacf1357e675247dd317e4f6e3b6 Author: Elodie Banel <lod@google.com> Date: Fri Aug 10 15:08:11 2018 Add function for a11y omnibox security state and fix ios After https://chromium-review.googlesource.com/c/chromium/src/+/1140674 the GetSecureVerboseText function doesn't return text anymore. This function is used for visual display. In order to continue getting data for accessibility purposes, duplicate the function with modifications to continue returning relevant info. Additionally, fix iOS omnibox accessibility to 1) use this new function and 2) update a11y when label (generally site url) changes even if security state does not. Bug: 869398 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibf60a354d5f81b9a5d52aaec10d3ef5277be93bd Reviewed-on: https://chromium-review.googlesource.com/1161913 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582165} [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/components/toolbar/test_toolbar_model.cc [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/components/toolbar/test_toolbar_model.h [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/components/toolbar/toolbar_model.h [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/components/toolbar/toolbar_model_impl.cc [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/components/toolbar/toolbar_model_impl.h [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/ios/chrome/browser/ui/location_bar/location_bar_steady_view.h [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm [modify] https://crrev.com/89c85f7cc4b4cacf1357e675247dd317e4f6e3b6/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
,
Aug 10
,
Aug 10
,
Aug 14
Verified on 70.0.3521.0 Canary on iPhone 6iOS 12 Beta #5 ,iPhoneX iOS 11.4 , iPad Pro 12'9 iOS 10.3.3 Voice over reads both "Address and Search bar, Search or Type URL" button and the current url name.
,
Aug 16
@stkhapugin - Approving this merge, please merge to M69 asap.
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b commit 9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b Author: Elodie Banel <lod@google.com> Date: Mon Aug 20 15:48:39 2018 Add function for a11y omnibox security state and fix ios After https://chromium-review.googlesource.com/c/chromium/src/+/1140674 the GetSecureVerboseText function doesn't return text anymore. This function is used for visual display. In order to continue getting data for accessibility purposes, duplicate the function with modifications to continue returning relevant info. Additionally, fix iOS omnibox accessibility to 1) use this new function and 2) update a11y when label (generally site url) changes even if security state does not. Bug: 869398 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibf60a354d5f81b9a5d52aaec10d3ef5277be93bd Reviewed-on: https://chromium-review.googlesource.com/1161913 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#582165}(cherry picked from commit 89c85f7cc4b4cacf1357e675247dd317e4f6e3b6) Reviewed-on: https://chromium-review.googlesource.com/1181401 Cr-Commit-Position: refs/branch-heads/3497@{#712} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/components/toolbar/test_toolbar_model.cc [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/components/toolbar/test_toolbar_model.h [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/components/toolbar/toolbar_model.h [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/components/toolbar/toolbar_model_impl.cc [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/components/toolbar/toolbar_model_impl.h [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/ios/chrome/browser/ui/location_bar/location_bar_steady_view.h [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm [modify] https://crrev.com/9ebea1d647ef9249c4bcb1c77cd2242c18c24b2b/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
,
Aug 21
,
Aug 22
Verified on M69.0.3497.53 beta iOS: 11.4.1, iPad Pro. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by srikanthg@chromium.org
, Jul 31