Passwords dropdown on desktop: hide overflowing bullet characters |
||||||||||||||||
Issue descriptionWhat is the expected result? Overflowing password bullet character should be hidden, see specs: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZRT3KyGvNYc6/files/MCEGxH4Xyp10GcTPe49gBVxzwMSJbxAVNpw. What happens instead? Passwords are truncated with an ellipsis (...).
,
Jul 31
Yup!
,
Jul 31
You make this look too easy Vasilii! Jokes aside, thanks for the fast turnaround!
,
Jul 31
Thanks, Vasilii!
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9080a8ec38bbe99536df8574fa498a33ec4e95ff commit 9080a8ec38bbe99536df8574fa498a33ec4e95ff Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Jul 31 22:41:22 2018 Truncate password in the drop-down. Currently ellipsis is added to the value but it should be just truncated. Bug: 869394 Change-Id: I68cee8a70a45564ace59512356489c195327ca1c Reviewed-on: https://chromium-review.googlesource.com/1156696 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579604} [modify] https://crrev.com/9080a8ec38bbe99536df8574fa498a33ec4e95ff/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
Aug 1
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b18d8951e795978764d086e4e8e8b8291b3d9758 commit b18d8951e795978764d086e4e8e8b8291b3d9758 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Aug 02 11:23:42 2018 Truncate password in the drop-down. Currently ellipsis is added to the value but it should be just truncated. TBR=vasilii@chromium.org (cherry picked from commit 9080a8ec38bbe99536df8574fa498a33ec4e95ff) Bug: 869394 Change-Id: I68cee8a70a45564ace59512356489c195327ca1c Reviewed-on: https://chromium-review.googlesource.com/1156696 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579604} Reviewed-on: https://chromium-review.googlesource.com/1160441 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#334} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/b18d8951e795978764d086e4e8e8b8291b3d9758/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
Aug 2
,
Aug 3
Tested this issue on windows 10, Mac 10.13.6 & Debian Rodate using chrome latest canary-70.0.3511.0 as per below steps:
1. Launch chrome
2. Navigate to below URL.
http://rsolomakhin.github.io/autofill/
3. Scroll down & go to 'Name/Password' section
4. Click on any of the 'NP Fill Form' button and observe username & password fields are getting filled
5. Enter more number of characters in Password field
6. Click on 'Submit' button
7. Save the password successfully (save bubble)
8. Refresh the page
9. Click on 'Name' filed of 'Name/password' section and observe 'Overflowing bullet characters are not hidden' on Win & Mac
10. Click on 'Password' filed of 'Name/password' section and observe 'Overflowing bullet characters are not hidden' on Win & Mac
Overflowing bullet characters are hidden only on Debian OS when we click on either Name or Password fields.
hence issue working as intended only on Linux & still issue seen on windows & Mac OS.
Please find the attached screencast for reference & confirm on the fix.
Thanks..!
,
Aug 3
OMG, you still have the old drop-down in Mac & Win on Canary. It should be in production in M69 already. Did you change some flags? What's the status of #top-chrome-md in chrome://flags?
,
Aug 6
Response to C#12. #top-chrome-md is 'Default' in chrome://flags on all OS. Thanks..!
,
Aug 6
Can you give a screenshot of chrome://flags ? Reset all the flags to default.
,
Aug 6
jmukthavaram@: can you please enable chrome://flags/#upcoming-ui-features for testing? The new UI is still not enabled by default. XFR bits have just been flipped, and as soon as we have leadership approval, we will enable the flag by default. After rolling out to 100% stable, we will delete the code for the old UI. In the meantime, I don't think it's worth fixing issues on the old UI.
,
Aug 7
ftirelo@, Thanks for the reply. Tested this issue on Windows 10, Mac 10,13.6 & debian using chrome latest canary-70.0.3514.0 as per C#11 & C#15.Overflowing bullet characters are hidden on Windows, Mac & Debian OS when we click on either Name or Password fields.As issue working as intended on all OS ,adding TE Verified labels. Please find the attached screencast for reference. Thanks..!
,
Aug 9
Tested this issue on Windows 10, Mac 10,13.6 & debian using chrome#69.0.3497.32 as per C#11 & C#15.Overflowing bullet characters are hidden on Windows, Mac & Debian OS when we click on either Name or Password fields.As issue working as intended on all OS ,adding TE Verified labels. Please find the attached screencast for reference. Thanks..! |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by nepper@chromium.org
, Jul 31