Remove Most Visited tiles animation is wrong |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Long press on a most visited tiles (on NTP) (2) Tap "Delete" What is the expected result? Only the delete most visited tile should be animated. What happens instead? All the tiles are animated.
,
Aug 6
When user hits Remove, the animation looks weird
,
Aug 7
,
Aug 18
gambard@ It looks like this was filed the same the same time this landed? https://chromium-review.googlesource.com/c/chromium/src/+/1154986 Reverting this seems to fix it (but that's a bad idea) I'll update it to not animate. wdyt?
,
Aug 18
,
Aug 20
Yes I know that this CL introduced it. I don't think it is a good idea to revert it neither. I see two solutions: - We remove the animations but then we loose the animations for the hide/show of the articles (I think). - We revert the reloadSection: back to its original implementation and we move the current implementation to a new method that is called for the show/hide.
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee73c1cdfe06785c8aa16ca73471fc53e3755e69 commit ee73c1cdfe06785c8aa16ca73471fc53e3755e69 Author: Justin Cohen <justincohen@google.com> Date: Tue Aug 21 04:07:12 2018 [ios] Remove NTP animation on -reloadSection. Bug: 869392 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id49d6eb03cecf76d8ed7ec476f300b6b4cb5de23 Reviewed-on: https://chromium-review.googlesource.com/1180550 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584647} [modify] https://crrev.com/ee73c1cdfe06785c8aa16ca73471fc53e3755e69/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
,
Aug 21
,
Aug 29
Verified in 70.0.3534.0 Canary in iPhone 7plus(iOS 10.3.3), iPhone 8plus(iOS 12 beta 11), iPhone 8plus(iOS 11.4.1) and iPad Air(iOS 11.4.1) No animation on removing most visited tiles, looks good Link to video: https://drive.google.com/file/d/1jDXPURLc9z7ZUpmvaDVjzHMTgnCus91w/view?usp=sharing |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fgor...@chromium.org
, Jul 31