New issue
Advanced search Search tips

Issue 869384 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"DefaultSearchProviderEnabled":false = Chrome crashes when "?" ist typed in omnibox

Reported by eatinggl...@gmail.com, Jul 31

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.75 Safari/537.36

Steps to reproduce the problem:
1. Set Policy-Setting "Default Searchprovider enabled" to disabled OR set registry HKCU\Software\Policies\Google\Chrome -> DefaultSearchProviderEnabled "0"
2. Open Chrome
3. Type "?" (w/o quotation marks) in the omnibox

What is the expected behavior?
Nothing should happen. Chrome should stay opened and the default search provider shouldn't be used.

What went wrong?
Chrome closes instantly w/o any error msg.

Did this work before? N/A 

Chrome version: 68.0.3440.75  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: none

You can contact me under eatingglass83@gmail.com
 
Status: Untriaged (was: Unconfirmed)
Verified behavior on both Stable 68.0.3440.75 and Dev 69.0.3493.3. It's not required to press enter; as soon as a question mark is typed in the omnibox Chrome immediately quits.

No other characters triggers the crash, only a question mark. Also, any preceding text prevents the crash. "a?" (no quotes) does not crash while "?" does.
Labels: Stability-Crash
Components: UI>Browser>Omnibox
[omnibox triage]

Even with the (likely) uncommon enterprise policy, I think this should be fixed.  I don't know who to assign it to at the moment, so leaving untriaged in the omnibox queue.
Cc: georgesak@chromium.org mpear...@chromium.org pastarmovj@chromium.org
Owner: nicolaso@chromium.org
Status: Assigned (was: Untriaged)
Hi Nicolas,

can you help figure out what's wrong here? Seems like this is easy to repro but we need to know what causes the crash and prevent it.
Hitting '?' normally causes the omnibox to enter 'Default Search Provider' mode. So, [1] is probably what is causing the crash.

I'll work on a fix right away. :-)

[1] https://cs.chromium.org/chromium/src/components/omnibox/browser/omnibox_edit_model.cc?l=1235&rcl=accb9e4e1822d9e050074b2108e426915b2ad7c5
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e98a790d5245feba119cf098ee4cbe094daf2efe

commit e98a790d5245feba119cf098ee4cbe094daf2efe
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Tue Aug 07 14:27:30 2018

Fix a crash with DefaultSearchProviderEnabled policy set to false

With the policy set to false, the browser used to crash when:
- The user enters '?' as the first character in the omnibar
- The user hits CTRL+K or CTRL+E to start a default search

Bug:  869384 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7b98bd7a745a8e66ffd22b1f972a5110e89a568c
Reviewed-on: https://chromium-review.googlesource.com/1162421
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581219}
[modify] https://crrev.com/e98a790d5245feba119cf098ee4cbe094daf2efe/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/e98a790d5245feba119cf098ee4cbe094daf2efe/chrome/browser/ui/omnibox/chrome_omnibox_client.h
[modify] https://crrev.com/e98a790d5245feba119cf098ee4cbe094daf2efe/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/e98a790d5245feba119cf098ee4cbe094daf2efe/components/omnibox/browser/omnibox_client.cc
[modify] https://crrev.com/e98a790d5245feba119cf098ee4cbe094daf2efe/components/omnibox/browser/omnibox_client.h
[modify] https://crrev.com/e98a790d5245feba119cf098ee4cbe094daf2efe/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/e98a790d5245feba119cf098ee4cbe094daf2efe/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.h
[modify] https://crrev.com/e98a790d5245feba119cf098ee4cbe094daf2efe/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm

Status: Fixed (was: Assigned)
Filed bug 871898 for follow-up work.  In particular, the fix above introduce a new helper function that should be used elsewhere in the omnibox code.  Mostly it's a code health issue, though I wouldn't be surprised if there were both crashes and functionality edge cases that still exist.

Sign in to add a comment