New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869381 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 746956



Sign in to add a comment

Compile //components with jumbo

Project Member Reported by osc...@opera.com, Jul 31

Issue description

//components takes around 100 CPU minutes to compile, which is around 17 % of the total build time.

Many of components sub-target has not been jumbofied, doing this would lead to a decrease in build time when building with jumbo.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cad55cd176a05fdc0fefa161b60e7b12b4158675

commit cad55cd176a05fdc0fefa161b60e7b12b4158675
Author: Oscar Johansson <oscarj@opera.com>
Date: Wed Aug 01 11:39:19 2018

Resolve namespace scope issue (components/autofill)

When building using jumbo, files get merged. This
results in a conflict with the namespace i18n.
This commit solves the issue bu specifying that the
global namespace should be used, by addind the
"::" prefix.

Bug: 869381
Change-Id: I3432251c5f91fbb1f35df6ef5a9c70337df5e21f
Reviewed-on: https://chromium-review.googlesource.com/1156601
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#579765}
[modify] https://crrev.com/cad55cd176a05fdc0fefa161b60e7b12b4158675/components/autofill/core/browser/autofill_address_util.cc
[modify] https://crrev.com/cad55cd176a05fdc0fefa161b60e7b12b4158675/components/autofill/core/browser/autofill_profile.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89e08521c5ea9999fe343424cfc5d6723dca97a0

commit 89e08521c5ea9999fe343424cfc5d6723dca97a0
Author: Oscar Johansson <oscarj@opera.com>
Date: Wed Aug 01 11:44:57 2018

Renaming conflicting variables names (components/autofill)

When building using jumbo, files get merged and variables
and functions with the same name may end up in the same
namespace/scope and conflict.

This commit solves the issues in components/autofill
by renaming the conflicting functions and variables to
something more file specific.

Bug: 869381
Change-Id: Ifccae861ca7379346fb0939113ac227b770f9640
Reviewed-on: https://chromium-review.googlesource.com/1158235
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#579768}
[modify] https://crrev.com/89e08521c5ea9999fe343424cfc5d6723dca97a0/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/89e08521c5ea9999fe343424cfc5d6723dca97a0/components/autofill/core/browser/autofill_handler.cc
[modify] https://crrev.com/89e08521c5ea9999fe343424cfc5d6723dca97a0/components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc
[modify] https://crrev.com/89e08521c5ea9999fe343424cfc5d6723dca97a0/components/autofill/core/common/form_data.cc
[modify] https://crrev.com/89e08521c5ea9999fe343424cfc5d6723dca97a0/components/autofill/core/common/form_field_data.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cedc263f223d9f418270ef37d75b663b2cdec41b

commit cedc263f223d9f418270ef37d75b663b2cdec41b
Author: Oscar Johansson <oscarj@opera.com>
Date: Wed Aug 01 12:36:10 2018

Move CreditCard function to util (/autofill)

When buidling using jumbo, files gets merged and functions
with the same name may end up in the same namespace and
conflict. This happens for the function IsCreditCardExporationType
in:
components/autofill/core/browser/form_structure.cc
components/autofill/core/browser/autofill_manager.cc

Since the functions are identical they are moved to a shared
util file. Since the function needs
components/autofill/core/browser/field_types.h it cannot be
moved to components/autofill/core/common.

Bug: 869381
Change-Id: I69492fbc8af0ed9289504cb6aba3e745acb17b24
Reviewed-on: https://chromium-review.googlesource.com/1158364
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579778}
[modify] https://crrev.com/cedc263f223d9f418270ef37d75b663b2cdec41b/components/autofill/core/browser/autofill_data_util.cc
[modify] https://crrev.com/cedc263f223d9f418270ef37d75b663b2cdec41b/components/autofill/core/browser/autofill_data_util.h
[modify] https://crrev.com/cedc263f223d9f418270ef37d75b663b2cdec41b/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/cedc263f223d9f418270ef37d75b663b2cdec41b/components/autofill/core/browser/form_structure.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20d0d540471f392f9c9bee0589ceeebb81376812

commit 20d0d540471f392f9c9bee0589ceeebb81376812
Author: Oscar Johansson <oscarj@opera.com>
Date: Thu Aug 02 08:32:22 2018

Enable jumbo support for //components/omnibox

Without jumbo, omnibox takes around 3 CPU minutes to build
which is around 0.5 % of the total build time.

This commit enables jumbo support in components/omnibox.

Bug: 869381
Change-Id: Ifb51dab5a6b034a384c6bf07ee2f5b8c17b952a7
Reviewed-on: https://chromium-review.googlesource.com/1156593
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#580114}
[modify] https://crrev.com/20d0d540471f392f9c9bee0589ceeebb81376812/components/omnibox/browser/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f0fa2e588f06f76c425651f608fe0e50c80e3ef

commit 0f0fa2e588f06f76c425651f608fe0e50c80e3ef
Author: Oscar Johansson <oscarj@opera.com>
Date: Thu Aug 02 12:35:03 2018

Move variable to util (components/autofill/)

When building using jumbo, files get merged and
variables with the same name may
end up in the same namespace and conflict.

This happens for the constant kLocalGuidSize in autofill/core/browser.
The variable is moved to a util file in
common.

Bug: 869381
Change-Id: I038ef40acd5617f9d9d1e18c81a2fcce55cab8eb
Reviewed-on: https://chromium-review.googlesource.com/1158544
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#580142}
[modify] https://crrev.com/0f0fa2e588f06f76c425651f608fe0e50c80e3ef/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/0f0fa2e588f06f76c425651f608fe0e50c80e3ef/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
[modify] https://crrev.com/0f0fa2e588f06f76c425651f608fe0e50c80e3ef/components/autofill/core/common/autofill_util.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/561f2872d21654a33f2427ba074a5652ef308096

commit 561f2872d21654a33f2427ba074a5652ef308096
Author: Oscar Johansson <oscarj@opera.com>
Date: Fri Aug 03 08:57:42 2018

Rename LoginTableColumns (components/password_manager)

When building using jumbo, files gets merged and enums
with the same name may end up in the same namespace and
conflict. This happens for he enum LoginTableColumns.

This commit solves the issue by renaming one instance
of LoginTableColumns to something more file specific.

Bug: 869381
Change-Id: I9a0b95dcddee3bbc9f1b8969142aa683e11025a0
Reviewed-on: https://chromium-review.googlesource.com/1160496
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#580482}
[modify] https://crrev.com/561f2872d21654a33f2427ba074a5652ef308096/components/password_manager/core/browser/login_database.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82bdeffe9af4610d0cba16601c94c7bc0b79c742

commit 82bdeffe9af4610d0cba16601c94c7bc0b79c742
Author: Oscar Johansson <oscarj@opera.com>
Date: Fri Aug 03 08:57:45 2018

Rename UserDataKey to be unique (components/autofill)

When building using jumbo, files gets merged and
functions with the same name may end up in the same
namespace/scope and conflict. This happens for
the function UserDataKey. Since the function relies
on that the static int is unique this function could
not be moved to a shared util file. Instead, the issue
was solved by renaming the function.

Bug: 869381
Change-Id: Ifd67ac865e9d0bad272cc51ef1af8c3a5b382893
Reviewed-on: https://chromium-review.googlesource.com/1160487
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#580483}
[modify] https://crrev.com/82bdeffe9af4610d0cba16601c94c7bc0b79c742/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
[modify] https://crrev.com/82bdeffe9af4610d0cba16601c94c7bc0b79c742/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
[modify] https://crrev.com/82bdeffe9af4610d0cba16601c94c7bc0b79c742/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/82bdeffe9af4610d0cba16601c94c7bc0b79c742/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4faf26aed6f5a43f741fd2244904159f6c515a36

commit 4faf26aed6f5a43f741fd2244904159f6c515a36
Author: Oscar Johansson <oscarj@opera.com>
Date: Fri Aug 03 12:26:40 2018

Move function to util (components/password_manager/)

When building using jumbo, files gets merged and
functions with the same name may end up in the same
namespace/scope and conflict. This happens for the
function UpdateMetadataForUsage.

This commit solves the issue by moving the function
to a shared util file.

Bug: 869381
Change-Id: I57b8f9c96c785a3bbfc8250f0edbe7690c3b3ff7
Reviewed-on: https://chromium-review.googlesource.com/1160482
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580514}
[modify] https://crrev.com/4faf26aed6f5a43f741fd2244904159f6c515a36/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/4faf26aed6f5a43f741fd2244904159f6c515a36/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/4faf26aed6f5a43f741fd2244904159f6c515a36/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/4faf26aed6f5a43f741fd2244904159f6c515a36/components/password_manager/core/browser/password_manager_util.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faa3159fb49410f1af95d9e466573c9dcfc77b6c

commit faa3159fb49410f1af95d9e466573c9dcfc77b6c
Author: Oscar Johansson <oscarj@opera.com>
Date: Wed Aug 08 12:16:14 2018

Forward declare operator overload (components/)

When building using jumbo, files get merged and more options
are presented for the compiler. When using the operator overload <<
in PasswordRequirementsSpec, the compiler gets too many
options and will fail before reaching the correct operator overload.

The issue solved by forward declaring the operator overload in the files
that uses it.

Bug: 869381
Change-Id: I3d0226c9e12b1e64b3359a1efb2f9948a24e61b6
Reviewed-on: https://chromium-review.googlesource.com/1160228
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#581526}
[modify] https://crrev.com/faa3159fb49410f1af95d9e466573c9dcfc77b6c/components/autofill/core/browser/password_requirements_spec_printer.cc
[modify] https://crrev.com/faa3159fb49410f1af95d9e466573c9dcfc77b6c/components/autofill/core/browser/password_requirements_spec_printer.h

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0abada471383f1dab147d9692525cad4175ff4e

commit a0abada471383f1dab147d9692525cad4175ff4e
Author: Oscar Johansson <oscarj@opera.com>
Date: Thu Aug 09 11:26:11 2018

Specify autofill::AddressField (component/autofill)

When building using jumbo, files gets merged and
the compiler gets a larger scope. AddressField is
defined in both autofill::AddressField and
::i18n::addressinput::AddressField and the
reference is ambiguous. That is the reason
the namespace autofill:: needs to be specified
even though the call is made within that namespace.

Bug: 869381
Change-Id: I3ac8813403e04b37b7936397e617aab436214056
Reviewed-on: https://chromium-review.googlesource.com/1169012
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#581864}
[modify] https://crrev.com/a0abada471383f1dab147d9692525cad4175ff4e/components/autofill/core/browser/form_field.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7806c5dee24b303c4615f8e7cd295b6f59c1331

commit c7806c5dee24b303c4615f8e7cd295b6f59c1331
Author: Oscar Johansson <oscarj@opera.com>
Date: Thu Aug 09 11:32:36 2018

Move TruncateUTF8 to util (components/autofill)

When building using jumbo, files gets merged and
functions with the same name may end up in the
same namespace and conflict. This happens for
the function TruncateUTF8.

This commit solves the issue by moving the function
to a shared util file.

Bug: 869381
Change-Id: Ia9f754138fb18aa9af575f7cd2f92bca4e8ea0c2
Reviewed-on: https://chromium-review.googlesource.com/1168497
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#581866}
[modify] https://crrev.com/c7806c5dee24b303c4615f8e7cd295b6f59c1331/components/autofill/core/browser/autofill_data_util.cc
[modify] https://crrev.com/c7806c5dee24b303c4615f8e7cd295b6f59c1331/components/autofill/core/browser/autofill_data_util.h
[modify] https://crrev.com/c7806c5dee24b303c4615f8e7cd295b6f59c1331/components/autofill/core/browser/autofill_profile_sync_util.cc
[modify] https://crrev.com/c7806c5dee24b303c4615f8e7cd295b6f59c1331/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/684fe296be634a7fcdcd64f3f10e7870aa9bb3de

commit 684fe296be634a7fcdcd64f3f10e7870aa9bb3de
Author: Oscar Johansson <oscarj@opera.com>
Date: Thu Aug 09 11:36:08 2018

Make function names unique (components/autofill)

When building using jumbo, files gets merged and
functions with the same name may end up in the
same namespace and conflict. This happens for
functions in:
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc

The functions are very similar but not identical. Therefore,
the functions in
components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
are renamed to be something more file specific.

Bug: 869381
Change-Id: I8b26857cfa9fd80b42d9ff79de4b49753c824b54
Reviewed-on: https://chromium-review.googlesource.com/1169018
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#581867}
[modify] https://crrev.com/684fe296be634a7fcdcd64f3f10e7870aa9bb3de/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c356a9697625b3c25856529908af0c3253dfa2c

commit 9c356a9697625b3c25856529908af0c3253dfa2c
Author: Oscar Johansson <oscarj@opera.com>
Date: Fri Aug 10 10:09:55 2018

Enable jumbo support in components/autofill

//components/autofill takes 6.6 CPU minutes to compile.
With jumbo and chunk size = 50 the build time is reduced
by around 54 %.

This commit enables jumbo support in components/autofill.

Bug: 869381
Change-Id: Iba405b8c2199f68c11a13ee0872bfaae87943d7f
Reviewed-on: https://chromium-review.googlesource.com/1170689
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#582105}
[modify] https://crrev.com/9c356a9697625b3c25856529908af0c3253dfa2c/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/9c356a9697625b3c25856529908af0c3253dfa2c/components/autofill/content/renderer/BUILD.gn
[modify] https://crrev.com/9c356a9697625b3c25856529908af0c3253dfa2c/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/9c356a9697625b3c25856529908af0c3253dfa2c/components/autofill/core/common/BUILD.gn

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09e1e7978fb4e02fd4f94bbac8c000f73cfd36ca

commit 09e1e7978fb4e02fd4f94bbac8c000f73cfd36ca
Author: Oscar Johansson <oscarj@opera.com>
Date: Fri Aug 10 10:37:15 2018

Enable jumbo support in components/password_manager/

Without jumbo, password_manager takes around 3.6 CPU
minutes to build. With jumbo and chunk size 50,
password_manager takes around 11 seconds to build,
a decrease by around 94 %.

This commit enables jumbo support in
components/password_manager.

Bug: 869381
Change-Id: Icce9d9800a01d452d63ba137c52c2a0495359da8
Reviewed-on: https://chromium-review.googlesource.com/1166963
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582109}
[modify] https://crrev.com/09e1e7978fb4e02fd4f94bbac8c000f73cfd36ca/components/password_manager/content/browser/BUILD.gn
[modify] https://crrev.com/09e1e7978fb4e02fd4f94bbac8c000f73cfd36ca/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/09e1e7978fb4e02fd4f94bbac8c000f73cfd36ca/components/password_manager/core/common/BUILD.gn
[modify] https://crrev.com/09e1e7978fb4e02fd4f94bbac8c000f73cfd36ca/components/password_manager/sync/browser/BUILD.gn

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/426aa9fbfc3760128ea812375d311972d73033e9

commit 426aa9fbfc3760128ea812375d311972d73033e9
Author: Byoungkown <codeimpl@gmail.com>
Date: Thu Sep 06 17:22:42 2018

[Jumbo] Enable jumbo support for //components/wifi

After adding "use_jumbo_build=true" args in GN, jumbo build can be
enabled.

Bug: 869381
Change-Id: Ia95bfd39e2f8f5b7ab1df879d12433341245d046
Reviewed-on: https://chromium-review.googlesource.com/1204372
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589203}
[modify] https://crrev.com/426aa9fbfc3760128ea812375d311972d73033e9/components/wifi/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c656c53ed81918c6a89a6d90c962a1d9e95515be

commit c656c53ed81918c6a89a6d90c962a1d9e95515be
Author: Byoungkown <codeimpl@gmail.com>
Date: Thu Sep 06 21:36:21 2018

[Jumbo] Rename collision functions and enable jumbo build

GetPrefName function are collision with jumbo, so we need to change
name to avoid build fail with jumbo.
And enable jumbo build in components/content_settings/.
Use jumbo build after adding "use_jumbo_build=true" args in GN.

Bug: 869381
Change-Id: Ic45971922b4c34cb7deb48e246da145e752e5383
Reviewed-on: https://chromium-review.googlesource.com/1203478
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#589313}
[modify] https://crrev.com/c656c53ed81918c6a89a6d90c962a1d9e95515be/components/content_settings/core/browser/BUILD.gn
[modify] https://crrev.com/c656c53ed81918c6a89a6d90c962a1d9e95515be/components/content_settings/core/browser/website_settings_info.cc
[modify] https://crrev.com/c656c53ed81918c6a89a6d90c962a1d9e95515be/components/content_settings/core/common/BUILD.gn
[modify] https://crrev.com/c656c53ed81918c6a89a6d90c962a1d9e95515be/components/content_settings/core/test/BUILD.gn

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48aadca678213aacc4fe40b16deb444a0c7b3e5e

commit 48aadca678213aacc4fe40b16deb444a0c7b3e5e
Author: Byoungkown <codeimpl@gmail.com>
Date: Fri Sep 21 06:13:59 2018

[Jumbo] Add jumbo feature to build fast

After adding "use_jumbo_build=true" args in GN, jumbo build can be
enable.

Bug: 869381
Change-Id: Ic6af47b97a7a6b1e39508d9c757bb83bab01b194
Reviewed-on: https://chromium-review.googlesource.com/1204371
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#593092}
[modify] https://crrev.com/48aadca678213aacc4fe40b16deb444a0c7b3e5e/components/security_state/content/BUILD.gn
[modify] https://crrev.com/48aadca678213aacc4fe40b16deb444a0c7b3e5e/components/security_state/core/BUILD.gn
[modify] https://crrev.com/48aadca678213aacc4fe40b16deb444a0c7b3e5e/components/security_state/ios/BUILD.gn

Blocking: 746956
Cc: osc...@opera.com codei...@gmail.com brat...@opera.com
Components: Build
Owner: ----
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f49184171c96b9accecf134e9420726b9a5e7f0c

commit f49184171c96b9accecf134e9420726b9a5e7f0c
Author: Byoungkown <codeimpl@gmail.com>
Date: Mon Oct 01 17:09:49 2018

[Jumbo] Add support for jumbo compilation in components/metrics

The code in components/metrics takes about >3CPU minutes to build.
Building effort will fall to about 1 CPU minutes using jumbo builds[1].
When building using jumbo, files gets merged.
It means that you cannot duplicate symbol names within the component,
not even in anonymous namespaces.

[1] https://chromium.googlesource.com/chromium/src/+/lkgr/docs/jumbo.md

Bug: 869381
Change-Id: I5287f8366ea78b6e97c51d04489ec3c2ed28fab6
Reviewed-on: https://chromium-review.googlesource.com/1239133
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595473}
[modify] https://crrev.com/f49184171c96b9accecf134e9420726b9a5e7f0c/components/metrics/BUILD.gn

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d03b45496f7bc0c5b780943f9a4e4fba4b133257

commit d03b45496f7bc0c5b780943f9a4e4fba4b133257
Author: Byoungkown <codeimpl@gmail.com>
Date: Thu Oct 04 04:34:31 2018

[Jumbo] Add support for jumbo compilation in components/policy

The code in components/policy takes about 3-4 CPU minutes to build.
Building effort will fall to about 1 CPU minutes using jumbo builds[1].
When building using jumbo, files get merged and variables and functions
with the same name may end up in the same namespace/scope and conflict.
One PolicyLoadStatus is in core/common/cloud/user_cloud_policy_store.cc
and the other PolicyLoadStatus is in core/common/policy_load_status.h.
PolicyLoadStatus is renamed in core/common/policy_load_status.h to
avoid conflict as PolicyLoadStatusForUma.

[1] https://chromium.googlesource.com/chromium/src/+/lkgr/docs/jumbo.md

Bug: 869381
Change-Id: I268603abca0be7ed029d60bd1531ca41983c3ece
Reviewed-on: https://chromium-review.googlesource.com/c/1253313
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#596502}
[modify] https://crrev.com/d03b45496f7bc0c5b780943f9a4e4fba4b133257/components/policy/content/BUILD.gn
[modify] https://crrev.com/d03b45496f7bc0c5b780943f9a4e4fba4b133257/components/policy/core/browser/BUILD.gn
[modify] https://crrev.com/d03b45496f7bc0c5b780943f9a4e4fba4b133257/components/policy/core/common/BUILD.gn
[modify] https://crrev.com/d03b45496f7bc0c5b780943f9a4e4fba4b133257/components/policy/core/common/cloud/user_cloud_policy_store.cc

Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.

Sign in to add a comment