New issue
Advanced search Search tips

Issue 869379 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Font size reset on rotation

Project Member Reported by gambard@chromium.org, Jul 31

Issue description

What steps will reproduce the problem?
(1) Open a page
(2) Scroll to enter fullscreen
(3) Rotate the phone

What is the expected result?
Font size should stays the same as the toolbar is still in fullscreen.

What happens instead?
The font size is bumped back to its original size.
 
Labels: -Pri-2 M-70 Pri-1
Labels: -Q2
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947bd6822b65326572ffb708c6700187799dd10a

commit 947bd6822b65326572ffb708c6700187799dd10a
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Aug 20 12:42:45 2018

[iOS] Do not reset the location bar font size on rotation.

Avoids resetting the scale when -resetTransform is called.

Bug:  869379 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id649065208060cf1c3fbd4394947acad2f67cec3
Reviewed-on: https://chromium-review.googlesource.com/1180896
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584414}
[modify] https://crrev.com/947bd6822b65326572ffb708c6700187799dd10a/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
[modify] https://crrev.com/947bd6822b65326572ffb708c6700187799dd10a/ios/chrome/browser/ui/orchestrator/location_bar_animatee.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified the issue on the build version 70.0.3535.0 canary tested on iPhone7+(iOS 11.4.1).
Font size is same both in portrait mode and landscape mode when the application is in full screen.

Video :
https://drive.google.com/file/d/1g3G7v_eZJ_cyMyZFE0OGVH1klm_F3yD-/view?usp=sharing
Issue 881266 has been merged into this issue.

Sign in to add a comment