wpt import: rebaseline-cl failed to collapse expectations |
|||
Issue descriptionWPT imports such as https://chromium-review.googlesource.com/c/chromium/src/+/1156252 were failing due to https://chromium-review.googlesource.com/c/chromium/src/+/1120431 and the work to reenable layout tests on Android. The latter CL added some [ Failure ] expectations for Android, but it turns out some of those tests are crashing on android_blink_rel. Specifically, https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22167 said: 2018-07-31 04:19:54,552 - Lines to write to TestExpectations: 2018-07-31 04:19:54,552 - crbug.com/626703 [ Android ] external/wpt/bluetooth/requestDevice/canonicalizeFilter/no-arguments.https.html [ Crash ] Given that tests already has a [ Failure ] expectation, I thought the [ Crash ] one would just be added to the existing entry. Instead, rebaseline-cl ended up adding another line to TestExpectations, which then failed a presubmit check.
,
Nov 7
See this again today: https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket.appspot.com/8930516527553529440/+/steps/Import_changes_from_WPT_to_Chromium/0/stdout I feel like the current way to add expectations (inserting raw lines into a text file) can't get us there. And I think we need to refactor the updater to support proper CRUD operations. Blocked on 891897.
,
Nov 28
|
|||
►
Sign in to add a comment |
|||
Comment 1 by markdittmer@chromium.org
, Aug 6Status: Assigned (was: Unconfirmed)