New issue
Advanced search Search tips

Issue 869359 link

Starred by 1 user
Status: WontFix
Owner:
pbos@chromium.org
Closed: Jul 31
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
ellyjo...@chromium.org
bettes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Focus ring gets chopped for extension icon which have entries/counts at their bottom.

Reported by shruti.j...@etouch.net, Jul 31 
Chrome Version:70.0.3508.0 (Official Build)  Revision	9271ffcc91216f5c818f30b577c846306a469ad9-refs/branch-heads/3508@{#1}(64-bit)
OS:  Mac(10.12.6, 10.13.1, 10.13.6, 10.14).

Pre-Condiiton: Enable 'Use Views browser windows instead of Cocoa' flag from chrome://flags and relaunch the browser.

Test URL:https://chrome.google.com/webstore/detail/clickclean/ghgabhipcejejjmhhchfonmamedcbeod?utm_source=chrome-ntp-icon

Steps to reproduce:
1.Launch chrome ,Navigate to above URL.
2.Download the extension and press tab and bring focus on extension icon present in omnibox.
3.Observe focus ring on Extension which have some entries below it.

Actual Result: Focus ring gets chopped for extension icon which have entries/counts at their bottom.
Expected Result:Focus ring should cover complete extension icon having entries/counts on its bottom.

This is a regression issue, broken in 'M-69', and below is  per-revision bisect-info:
Good Build:69.0.3494.0(Revision:578159)
Bad Build: 69.0.3495.0(Revision:577394)

You are probably looking for a change made after 575652 (known good), but no later than 575653 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/55388b6fbd2b571230a861cc6e73e8ce21664186..38410b62b95dae578cc342954f91f227de4315f3

Suspect:https://chromium.googlesource.com/chromium/src/+/38410b62b95dae578cc342954f91f227de4315f3

@Peter Boström: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast 
Thank You.
Actual_Result.mov
2.5 MB View Download
Expected_Result.mov
4.8 MB View Download

Comment 1 by pbos@chromium.org, Jul 31

Cc: ellyjo...@chromium.org
Labels: Proj-MdRefresh
+ellyjones@, WDYT, should we use a lower-radius RoundRect here or live with the clipping? We can't both have it match the underlying circle and not clip the message.

Comment 2 by robliao@chromium.org, Jul 31

Labels: -Pri-1 Group-Toolbar Pri-2

Comment 3 by pbos@chromium.org, Jul 31

Cc: bettes@chromium.org
+bettes@ as well, tbh I'm OK with this being clipped while the focus ring is active over it as it allows us to match shapes w/ the ink drop. I'd be interested in other opinions here.

Comment 4 by ellyjo...@chromium.org, Jul 31 

I would basically just live with the current behavior.

Comment 5 by pbos@chromium.org, Jul 31

Status: WontFix (was: Assigned)
Cool, WontFixing it. If this becomes a painpoint we can possibly also update the ring only for extensions with a displayed message, but no need to do that prematurely.
►

Sign in to add a comment