[RTL]Extension icons are not seen properly
Reported by
vineetha...@etouch.net,
Jul 31
|
|||||||
Issue descriptionChrome Version: 68.0.3440.84 (Official Build) Revision 520a5c14b858e4b1441dd2d3bab9bc745911a23b-refs/branch-heads/3440@{#774}(32/64-bit) OS: Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) What steps will reproduce the problem? 1. Launch Chrome, navigate to chrome://extensions page and enable "Developer mode" toggle button. 2. Click on ‘Load unpacked’ button and Install an extension for which errors can be found. 3. Now set 'Force UI Direction flag to 'Right-to-left' under chrome://flags and observe the extension icons on the LHS of omnibox. Actual :Extension icons are not seen properly instead question mark is seen on enabling RTL. Expected:Extension icons should be seen properly even after enabling RTL. This is a non-regression issue, seen from M-61 series Kindly review the attached screen-cast for reference. Note: This issue is not reproducible on Linux (14.04 LTS) OS. Thank you..!!
,
Aug 17
It's not obvious from the attached media what the bug is about icon, can you reupload the screencast?
,
Oct 5
,
Oct 5
,
Oct 5
Able to repro on Canary. kelvinjiang@, can you look into this?
,
Oct 19
Tried to repro in stable (70.0.3538.67) and Canary (72.0.3584.0) on OSX 10.13.6, Icons are still there after installing an extension with an error then forcing the text to be RTL rdevlin.cronin@ confirm?
,
Oct 26
(Just to close the loop here, confirmed offline that we were still able to repro this, and Kelvin is looking into it)
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e7f34f758dc85a641ff6105acf07e94799e4048 commit 9e7f34f758dc85a641ff6105acf07e94799e4048 Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Thu Nov 01 18:48:14 2018 [Extensions] Fix bug where placeholder extension icon is an unknown symbol (RTL) The placeholder icon for an extension is the first letter of the extension's name on a grey background. extension->name() (which we currently use) is padded with formatting characters if RTL mode is enabled, and grabbing the first character in that case does not get us the extension's actual name. Fix is implemented by reversing the RTL adjustment of the extension's name before getting the first letter. Bug: 869358 Change-Id: I986c2aade64e981ce634f5d14befd21df759d9cd TEST: This behavior is difficult to automatically test. To test manually: 1) Load an extension without an icon set in the manifest and note the appearance of the placeholder icon. 2) Navigate to chrome://flags and toggle "force ui direction" to RTL (search for rtl to find this flag), then click to relaunch when prompted. 3) The extension placeholder icon's appearance should not change and should show the first letter of the extension's name as defined in the manifest. Change-Id: I986c2aade64e981ce634f5d14befd21df759d9cd Reviewed-on: https://chromium-review.googlesource.com/c/1302633 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#604653} [modify] https://crrev.com/9e7f34f758dc85a641ff6105acf07e94799e4048/extensions/browser/extension_icon_placeholder.cc
,
Nov 2
Update : Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.13.1 , 10.13.6, 10.14.1) and Linux(14.04 LTS)OS with latest Canary version #72.0.3599.0 and the issue is fixed. Kindly refer the attached screen cast.
,
Nov 6
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nyerramilli@chromium.org
, Jul 31