Issue 868895  has been merged into this issue.

 Issue 860594  has been merged into this issue.

Non-blocking feedback for windows: The bottom arrow button of the scrollbar is hidden behind the win taskbar.

PM LGTM

Over to Max.

Cool, generally LGTM! One detail: on macOS the scrollbar should be hidden by default when using a modern trackpad or mouse that supports gestures. Could you check whether that's the case?

After changing the OS settings for "Show scroll bars" to "When scrolling" the scrollbar disappeared. Thus, it works. 

Cool, happy to try this out when it lands!

Adding an overview of the proposed scrolling behavior in different edge cases.

Deleted: Scrolling Behavior.png 125 KB

	Scrolling Behavior.png 125 KB View Download

Thanks! LGTM

I've a customer that is asking about this.
case: 16505634
do we have any ETA for this fix ?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a096eccb42822a1f3e58b52fa415ba6b24687951

commit a096eccb42822a1f3e58b52fa415ba6b24687951
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Aug 08 12:50:53 2018

Implement scrolling of the profile chooser in case it doesn't fit the screen.

Bug:  869343 
Change-Id: I41925fe4b045f8489c11986ecefee0ebd5f624c0
Reviewed-on: https://chromium-review.googlesource.com/1160537
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581533}
[modify] https://crrev.com/a096eccb42822a1f3e58b52fa415ba6b24687951/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/a096eccb42822a1f3e58b52fa415ba6b24687951/chrome/browser/ui/views/profiles/profile_chooser_view.h

Able to reproduce the issue on chrome version 70.0.3503.0 (build without fix) as per the comment #0.
Verified the fix on Windows 10 and Ububntu 17.10  using Chrome version # 70.0.3517.0.
Attaching screen-cast for reference.
Observed that " The profile chooser menu is scrollable " 
The fix is working as expected, adding Verified labels

NOTE: No new mac canary is available to verify this due to  Issue 872704  

Thanks...!!"

Deleted: 869343.mp4 1.5 MB

	869343.mp4 1.5 MB View Download

I'd like to merge r581533 back. The UI fix for the profile chooser was demanded by the privacy team.

This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Release managers: This bug fix was a launch blocking requirement from privacy. It blocks the launch of Autofill Home in M69.

Approving merge for r581533 to M69 branch 3497 based on comment #13, #14 & #16, pls merge before 4:00 PM PT Monday (08/13). Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9099141eaf7969b9a92c92d9d319685b33eb65fb

commit 9099141eaf7969b9a92c92d9d319685b33eb65fb
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Aug 13 08:52:43 2018

Implement scrolling of the profile chooser in case it doesn't fit the screen.

TBR=vasilii@chromium.org

(cherry picked from commit a096eccb42822a1f3e58b52fa415ba6b24687951)

Bug:  869343 
Change-Id: I41925fe4b045f8489c11986ecefee0ebd5f624c0
Reviewed-on: https://chromium-review.googlesource.com/1160537
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581533}
Reviewed-on: https://chromium-review.googlesource.com/1172284
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#560}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/9099141eaf7969b9a92c92d9d319685b33eb65fb/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/9099141eaf7969b9a92c92d9d319685b33eb65fb/chrome/browser/ui/views/profiles/profile_chooser_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e39a9a26a24e1e265d34196da1634831a6125302

commit e39a9a26a24e1e265d34196da1634831a6125302
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Aug 13 12:05:46 2018

Profile chooser: change minimal height before scrolling to 40dp.

Bug:  869343 
Change-Id: Ic3506c14a51fca41a8c5ee84587d5947976178df
Reviewed-on: https://chromium-review.googlesource.com/1172343
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582553}
[modify] https://crrev.com/e39a9a26a24e1e265d34196da1634831a6125302/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Is CL listed at #20 need a merge to M69?

No, I don't think it brings enough value.

Able to reproduce the issue on chrome version 70.0.3503.0 (build without fix) as per the comment #0.
Verified the fix on Windows 10, Ubuntu 17.10 and Mac 10.13.6 using Chrome version # 70.0.3522.0.
Attaching screen-cast for reference.
Observed that " The profile chooser menu is scrollable " 
The fix is working as expected, adding Verified labels

Thanks...! 

Deleted: 869343.mp4 1.2 MB

	869343.mp4 1.2 MB View Download

Verified the fix on Windows 10, Ubuntu 17.10 and Mac 10.13.6 using Chrome version # 69.0.3497.42.
Attaching screen-cast for reference.
Observed that " The profile chooser menu is scrollable " 
The fix is working as expected, adding Verified labels

Thanks...!

Deleted: 869343.mp4 2.0 MB

	869343.mp4 2.0 MB View Download

 Issue 878118  has been merged into this issue.

 Issue 880098  has been merged into this issue.