New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869341 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 18 days ago
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Google Apps icons are shifted towards left in Google local NTP using RTL.

Reported by sanyam.g...@etouch.net, Jul 31

Issue description

Chrome Version: 68.0.3440.84 (Official Build) Revision 520a5c14b858e4b1441dd2d3bab9bc745911a23b-refs/branch-heads/3440@{#774}(32/64-bit)
OS: Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux (14.04 LTS).

Pre-condition:
1. Enable 'Enable using the Google local NTP' under chrome://flags.
2. Set 'Force UI direction' to 'Right-to-left' under chrome://flags.

What steps will reproduce the problem?
1. Launch Chrome and Sign-in to chrome with valid credentials.
2. Open NTP, click on 'Google Apps' menu icon and Observe.

Actual: Google Apps icons are shifted towards left.
Expected: Google Apps icons should not be shifted towards left.

This is a non-regression issue, seen from M-68 series

Kindly review the attached screen-cast for reference.

Thank you..!!
 
Actual_Result.mp4
1.3 MB View Download
Labels: zine-triaged
Cc: kmilka@chromium.org
Labels: OS-Chrome
Thanks for your report.

Unfortunately, I haven't been able to reproduce it on 68.0.3440.84 on Mac 10.13.6 by setting the two flags documented here. I've tried in both signed-in and signed-out states.

Can you attach a screencast of how this looks when force-ui-direciton is Left-to-right?

Also, do you have a language set in Chrome, or in your google.com account?

Update: 
With respect to comment#2:
In stable build on 68.0.3440.84 on Mac (10.13.6) OS issue is reproducible and when force-UI-direction is Left-to-right Issue is not reproducible that is working as expected.

No language is set in chrome and My google.com account.

Attaching the screen cast for both the scenarios ,kindly refer from drive link
https://drive.google.com/open?id=1yRlfNlvNXjRkwtuurLbmQXeI019Mgzr4.

Thank You.
Cc: sweilun@chromium.org
Owner: sweilun@chromium.org
Status: Started (was: Assigned)
Please see https://bugs.chromium.org/p/chromium/issues/detail?id=871162#c3 for reference
Screenshot from 2018-08-07 13-04-01.png
75.8 KB View Download
Thanks for looking at this Weilun! Based on the screenshot in comment 6, it looks like this will be resolved by fixing  issue 871162 ? If so, you can mark this as blocked on 871162, and then close this bug once the fix for that one has landed.
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81684566d2778f74e9d07d4e3ac9a8cc320100a1

commit 81684566d2778f74e9d07d4e3ac9a8cc320100a1
Author: Weilun Shi <sweilun@chromium.org>
Date: Wed Aug 08 01:46:35 2018

[NTP] One Google Bar align to left when using rtl language

Change the one-google bar css setting from align to right to width:100%,
which consistent with the google.com setting. OGB can now automatically
align to left or right based on the language preference setting. Also,
the profile icon will not be invisible on rtl mode.

Please see https://bugs.chromium.org/p/chromium/issues/detail?id=871162#c3 for reference.

Bug:  869610 ,  869341 
Change-Id: Iac7e015a5506cd8bcd82ef94d237790210a5fba8
Reviewed-on: https://chromium-review.googlesource.com/1165534
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581434}
[modify] https://crrev.com/81684566d2778f74e9d07d4e3ac9a8cc320100a1/chrome/browser/resources/local_ntp/local_ntp.css

Status: Fixed (was: Started)
Update:
Rechecked the above issue on Win(7,8,8.1,10) and Linux(14.04) machines using latest canary build #70.0.3517.0 and issue is still reproducible.

Note: Mac build # 70.0.3517.0 is not available yet. Hence unable to verify on it.

Please refer below attached screen-cast for reference.

Thank You.
Canary Behaviour #70.0.3517.0.mp4
1.3 MB View Download
Please see https://bugs.chromium.org/p/chromium/issues/detail?id=871162#c3 for reference...

There is an error in the right-to-left flag and the correct way to open rtl mode is by typing "LANGUAGE=he path/to/chrome".
Labels: TE-Verified-M70 TE-Verified-70.0.3518.0
Update:
With respect to comment#13: Rechecked the above issue on Win(7,8,8.1,10),Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux(14.04) machines using latest canary build #70.0.3518.0 and issue is fixed.

Please refer below attached screen-cast for reference.

Thank You.
Fixed_Behaviour.mp4
1.6 MB View Download
Does this need to be added to remote NTP?
I think this one was always correct on the remote NTP

Sign in to add a comment