Non-Regression : Uber Tray is seen chopped in Images Preview of Files App |
||||||||
Issue descriptionChrome Version: 69.0.3497.21/10895.10.0 dev-channel Peppy,Candy and Reks OS: Chrome What steps will reproduce the problem? (1)Sign into User -> now open Uber Tray menu ->Take screenshot using 'Ctrl+F5(Overview Mode Button)' (2)Now go to Files App and switch to 'Thumbnail view' -> observe Uber Tray is seen chopped in Preview(In 'Thumbnail view' at Files App) and whereas in General Information page and Gallery Uber Tray is not chopped (Please refer Video) Expected: Uber Tray should not get chopped in Images Preview of Files App Actual: Instead Uber Tray is chopped This is Non-Regression Issue seen from M-62
,
Jul 31
,
Jul 31
,
Sep 11
I think this is working as intended.
There is a constant AUTO_FILL_THRESHOLD_DEFAULT_VALUE documented as
/**
* In percents (0.0 - 1.0), how much area can be cropped to fill an image
* in a container, when loading a thumbnail in FillMode.AUTO mode.
* The default 30% value allows to fill 16:9, 3:2 pictures in 4:3 element.
* @const {number}
*/
ThumbnailLoader.AUTO_FILL_THRESHOLD_DEFAULT_VALUE = 0.3;
All thumbnails are 4:3, and we've shipped chromebooks with aspect ratios of 3:2 (e.g chromebook pixel). 3:2 is narrower than 4:3, so the top/bottom of the thumbnail are getting cropped by design.
Please reopen if someone feels we should change this design. Otherwise, I think this is WontFix.
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/thumbnail_loader.js?q=AUTO_FILL_THRESHOLD_DEFAULT_VALUE&sq=package:chromium&g=0&l=108
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by weifangsun@chromium.org
, Jul 31Status: Available (was: Untriaged)