Regression: [Print Preview]Unnecessary preview page gets scrolled on pressing up/down arrow key.
Reported by
dchau...@etouch.net,
Jul 31
|
|||
Issue descriptionChrome Version: 70.0.3508.0 (Official Build) Revision 9271ffcc91216f5c818f30b577c846306a469ad9-refs/branch-heads/3508@{#1} 32/64-bit. OS: Win(7,8,8.1,10) and Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14). Precondition : Enable #enable-new-print-preview flag from chrome://flags Test-URL: https://en.wikipedia.org/wiki/Facebook What steps will reproduce the problem? 1. Launch Chrome, go to above URL or any large content of webpages and give print command. 2. Click on 'Change..' button under 'Destination' section to open 'Select a destination overlay'. 3 Press 'Tab' key from keyboard till focus reaches to first entry under 'Print Destinations' section. 4. Now press down arrow key from keyboard to select the next entry and observe the background page (preview page). Actual: Unnecessary background page (Preview page) gets scrolled on pressing up/down arrow key. Expected: Background page (Preview page) should not scroll on pressing up/down arrow key. This is a regression issue, broken in M-70 series, below is manual regression range: Good build: 70.0.3501.0 (Revision: 577394) Bad build: 70.0.3503.0 (Revision: 578159) Using the per-revision bisect providing the bisect results: You are probably looking for a change made after 577741 (known good), but no later than 577742 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/05d439bae59df4f21124c2bf2e7f96070fd0e796..b3d2f01439976295d1a529f29f2dd7ebe4482caf Suspecting: https://chromium.googlesource.com/chromium/src/+/b3d2f01439976295d1a529f29f2dd7ebe4482caf @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: This issue is not observed in Linux(14.04 LTS) machine. Kindly review the attached screen-cast for reference. Thank you.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb2126b85f31088f1fa43db482134a0f9cd18ba2 commit fb2126b85f31088f1fa43db482134a0f9cd18ba2 Author: rbpotter <rbpotter@chromium.org> Date: Fri Aug 03 14:12:46 2018 Print Preview: Fix key event handling in dialogs If a child dialog is focused, do not pass key events to the main Print Preview page. Bug: 869317 Change-Id: I0fd24ff715f92d39fc0f1f51a02688d630a8d219 Reviewed-on: https://chromium-review.googlesource.com/1159527 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#580534} [modify] https://crrev.com/fb2126b85f31088f1fa43db482134a0f9cd18ba2/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html [modify] https://crrev.com/fb2126b85f31088f1fa43db482134a0f9cd18ba2/chrome/browser/resources/print_preview/new/advanced_settings_dialog.js [modify] https://crrev.com/fb2126b85f31088f1fa43db482134a0f9cd18ba2/chrome/browser/resources/print_preview/new/destination_dialog.html [modify] https://crrev.com/fb2126b85f31088f1fa43db482134a0f9cd18ba2/chrome/browser/resources/print_preview/new/destination_dialog.js
,
Aug 6
Update: Rechecked the above issue on Win(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) machines using latest canary #70.0.3514.0 and issue is fixed. Hence adding TE-Verified labels. please refer below attached screen-cast for reference. Thank You.
,
Aug 7
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, Aug 1Status: Started (was: Assigned)