Change UX for Add new services menu |
||||||||||||
Issue descriptionFor M-69 we've changed the "Add new service" to the gear menu, however it uses an 2nd menu which is sub-optimal user flow. This bug is to track a better solution for it. Two possibilities are: 1. Use a sub-menu. 2. Use a dialog for the 2nd menu. Re-working the whole workflow is also a possibility.
,
Jul 31
Thanks for logging this! Here is an earlier exploration of the submenu pattern just to give an idea of how that might work. It's old stuff - will replace with newer specs in the future. https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZbHF01iRNpsj/files/MCEVSrWNo2D1owyXNKMdRshXwMSJbxAVNpw
,
Aug 6
,
Aug 15
,
Aug 16
,
Sep 10
,
Oct 2
,
Oct 4
,
Nov 7
,
Nov 19
,
Dec 10
,
Dec 10
,
Jan 21
(2 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d0e0740b7484132f565e4870ad7c312c0937934 commit 6d0e0740b7484132f565e4870ad7c312c0937934 Author: Alex Danilo <adanilo@chromium.org> Date: Mon Jan 21 08:14:49 2019 Change 'Add new service' to use sub-menu pattern. The gear menu (three dot menu at the top right of the Files App) has an 'Add new service' entry that triggers a second menu for services options. Existing behaviour is to activate that entry which closes the menu and opens a second menu with all the options available. This change uses the sub-menu implementation from https://chromium-review.googlesource.com/c/chromium/src/+/1364431 to enable the sub-menu behavior. Bug: 869282 Tests: Ran all browser and unit tests. Change-Id: Ibb67ccd18f7ade06bb9544b6ee999ee1b6361348 Reviewed-on: https://chromium-review.googlesource.com/c/1424622 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#624529} [modify] https://crrev.com/6d0e0740b7484132f565e4870ad7c312c0937934/ui/file_manager/file_manager/foreground/js/file_manager.js [modify] https://crrev.com/6d0e0740b7484132f565e4870ad7c312c0937934/ui/file_manager/file_manager/foreground/js/file_manager_commands.js [modify] https://crrev.com/6d0e0740b7484132f565e4870ad7c312c0937934/ui/file_manager/file_manager/foreground/js/gear_menu_controller.js [modify] https://crrev.com/6d0e0740b7484132f565e4870ad7c312c0937934/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js [modify] https://crrev.com/6d0e0740b7484132f565e4870ad7c312c0937934/ui/file_manager/file_manager/foreground/js/ui/providers_menu.js [modify] https://crrev.com/6d0e0740b7484132f565e4870ad7c312c0937934/ui/file_manager/file_manager/main.html
,
Yesterday
(35 hours ago)
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by lucmult@chromium.org
, Jul 31