This is inconsistent with the launcher, no? We only show the Terminal there if Crostini was installed on the machine. 

For users who have Crostini enabled on another device, I'm comfortable with either:
1) Showing Terminal icon in launcher/shelf, but triggering the setup flow if the user clicks it
2) Hiding the Terminal icon in launcher/shelf until the user explicitly goes through setup

I just want us to avoid having a blank space where Terminal was pinned on a different device.

I could not repro this bug. As far as I can tell, there might be a small delay before the icon shows up, but as soon as you interact with the launcher it appears.

However in the process of trying to repro this bug I did discover a related bug. When you click the Terminal icon on machine B and install Crostini, it unpins the Terminal icon on machine A.

Multiple people are still seeing this. The icon does not load even after clicking.

Feedback report: https://listnr.corp.google.com/report/85579927784
smbarber is also seeing a blank space on samus (which doesn't support crostini)

Seeing this on Gandof after beta 69; Terminal icon never appears in the launcher or shelf. Can't even start the container in crosh using vmc start method.

There is a large variety of bugs to do with syncing Crostini across two or more devices. I haven't filed them all yet, as they are all essentially the same problem. I'll chat to Tom about this tomorrow and update here.

I have spoken with Tom about this and decided on a goal. We want to leave most of the Crostini state unsynced, except for the pin & launcher position of Terminal on any machines where Terminal is installed (whether or not it is installed, however, will not be synced).

Step 1 will be to unsync the install state. This should resolve the most serious syncing pain.

Step 2 will be to add in syncing for pinning etc.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98d93c3ac577b3c9e680c7463595529c0f88924e

commit 98d93c3ac577b3c9e680c7463595529c0f88924e
Author: Timothy Loh <timloh@chromium.org>
Date: Tue Sep 11 04:07:23 2018

Don't display pinned Crostini apps if Crostini UI is not allowed

Due to either syncing or using multi-profile, we can get into a state
where synced pin state lists Crostini apps although we shouldn't be
displaying them. This results in weirdness like blank-space icons for
the Terminal, or penguin icons for apps with icons, when these pinned
items are supposed to be hidden. Clicking the shelf icons does nothing
due to https://crrev.com/c/1212373. This CL prevents these broken
pinned apps from appearing.

Bug:  869266 
Change-Id: I13ca91b8055cf43003bf1d467ca28161eb289e29
Reviewed-on: https://chromium-review.googlesource.com/1215532
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590196}
[modify] https://crrev.com/98d93c3ac577b3c9e680c7463595529c0f88924e/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/98d93c3ac577b3c9e680c7463595529c0f88924e/chrome/browser/ui/ash/launcher/launcher_controller_helper.cc

Approved for M70

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0b9c7fc9dd54c8eea290102748e3128852de82b

commit c0b9c7fc9dd54c8eea290102748e3128852de82b
Author: Timothy Loh <timloh@chromium.org>
Date: Fri Sep 14 01:34:52 2018

[M70 merge] Don't display pinned Crostini apps if Crostini UI is not allowed

Due to either syncing or using multi-profile, we can get into a state
where synced pin state lists Crostini apps although we shouldn't be
displaying them. This results in weirdness like blank-space icons for
the Terminal, or penguin icons for apps with icons, when these pinned
items are supposed to be hidden. Clicking the shelf icons does nothing
due to https://crrev.com/c/1212373. This CL prevents these broken
pinned apps from appearing.

Bug:  869266 
Change-Id: I13ca91b8055cf43003bf1d467ca28161eb289e29
Reviewed-on: https://chromium-review.googlesource.com/1215532
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590196}(cherry picked from commit 98d93c3ac577b3c9e680c7463595529c0f88924e)
Reviewed-on: https://chromium-review.googlesource.com/1225791
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#397}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/c0b9c7fc9dd54c8eea290102748e3128852de82b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/c0b9c7fc9dd54c8eea290102748e3128852de82b/chrome/browser/ui/ash/launcher/launcher_controller_helper.cc

Verified on M70-11021.34.0 and M71-11120.0.0.