[LayoutNG] compositing/layer-creation/stacking-context-overlap-nested.html |
|||
Issue description
The layer dump diff:
{
- "name": "LayoutBlockFlow (positioned) DIV class='composited box'",
- "bounds": [120, 120],
+ "name": "LayoutNGBlockFlow (positioned) DIV class='composited box'",
+ "bounds": [270, 170],
"backgroundColor": "#008000",
"transform": 1
},
https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/8499/layout-test-results/results.html
is because in NGPhysicalBoxFragment::SelfInkOverflow(), NG unites descendants outline rects even if it's oof, while legacy doesn't do this.
Not sure if we shouldn't do this, or outline rects should exclude oof, or something else.
atotic@, any ideas?
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d915d5c7d6ad8931fc70df08fc18d71dfe24e45 commit 8d915d5c7d6ad8931fc70df08fc18d71dfe24e45 Author: Koji Ishii <kojii@chromium.org> Date: Tue Jul 31 05:21:16 2018 [LayoutNG] Label its own bug number for compositing/layer-creation/stacking-context-overlap-nested.html TBR=atotic@chromium.org NOTRY=true Bug: 869265 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9a87e971df42fcef062344aae8a9bc34e7171ffd Reviewed-on: https://chromium-review.googlesource.com/1156116 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579318} [modify] https://crrev.com/8d915d5c7d6ad8931fc70df08fc18d71dfe24e45/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
,
Jul 31
LayoutInline::AddOutlineRects
-> LayoutInline::AddOutlineRectsForChildrenAndContinuations
-> LayoutBoxModelObject::AddOutlineRectsForNormalChildren
This seems to exclude OOF children.
// Outlines of out-of-flow positioned descendants are handled in
// LayoutBlock::addOutlineRects().
if (child->IsOutOfFlowPositioned())
continue;
,
Jul 31
Looks like legacy outline code path is quite complex. Maybe this isn't important enough to fix?
,
Oct 4
This test is no longer failing in LayoutNG.
,
Oct 5
Oh, awesome, I guess your outline CL fixed it then, thank you. |
|||
►
Sign in to add a comment |
|||
Comment 1 by kojii@chromium.org
, Jul 31