New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869262 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression
Q2



Sign in to add a comment

Text color in omnibox appears very light on changing search engine

Project Member Reported by subhashi...@chromium.org, Jul 31

Issue description

App Version: 69.0.3497.21 Beta
iOS Version: 10.3.3, 11.4.1 
Device: iPad Mini, iPad Pro (iPads only)

Steps to reproduce:
1. Launch iOS Chrome
2. Go to Menu>Settings>Search Engine
3. Change the search engine to ‘Yahoo’ or ‘Bing’
4. Open a New Tab Page
5. Go to Menu>Settings>Search Engine
6. Choose ‘Google’ as default search engine
7. Tap on Omnibox
8. Start typing any query
 
Observed results:
Text color is changed and appears very light 

Note: In few devices, it shows both fake & real omnibox at step 7

Expected results:
Text color should not change on changing search engine and should be clearly visible.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on the current beta channel build : M68, No

Type-bug-regression? Yes

Link to video/image:
https://drive.google.com/open?id=1h6l8A2u0SNWUByVbTCrjrXDX2lTDS_hQ



 
Cc: -stkhapugin@chromium.org
Labels: M-69 Q2
Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
Cc: gambard@chromium.org stkhapugin@chromium.org
Components: -UI>Browser>Omnibox UI>Browser>NewTabPage
Owner: justincohen@chromium.org
It seems like the fakebox to omnibox animation is broken, and that is probably caused by the NTP calculating the layout for the doodle and then removing the doodle? 
Labels: -Pri-1 Pri-2
Per discussion, dropping to P2.
Labels: zine-triaged
Labels: -M-69
Labels: -Pri-2 M-70 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/135ca470f325795782d8fce531716d93399ba9e8

commit 135ca470f325795782d8fce531716d93399ba9e8
Author: Justin Cohen <justincohen@google.com>
Date: Fri Aug 31 14:32:18 2018

[ios] Use the NTP's HeaderViewController traitCollection.

CSHVC isn't a typical child view controller because it's loaded inside a
UICollectionView header.  Perhaps due to this, in some situations the CSHVC.view
traitCollections appear to be UIUserInterfaceSizeClassUnspecified.  Instead
use CSHVC directly.

Bug:  869262 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ide7b1ecea10f056ef83004055122a91e08fd2fd9
Reviewed-on: https://chromium-review.googlesource.com/1196966
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588018}
[modify] https://crrev.com/135ca470f325795782d8fce531716d93399ba9e8/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm

Labels: Merge-Request-70
Status: Fixed (was: Started)
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 1

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 5

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: kariahda@chromium.org
Labels: -Merge-Approved-70 Merge-Merged-70
kariahda@ This was merged here: https://chromium-review.googlesource.com/c/chromium/src/+/1204933  Is there a problem with the merge-bot?
Yes merged correctly, Justin. Thanks for checking. We're getting a bug started for bugdroid.
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 5

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3712d6c683140cc585b6694ffc18b85cc40c9b6

commit f3712d6c683140cc585b6694ffc18b85cc40c9b6
Author: Justin Cohen <justincohen@google.com>
Date: Tue Sep 04 19:33:38 2018

[ios] Use the NTP's HeaderViewController traitCollection.

CSHVC isn't a typical child view controller because it's loaded inside a
UICollectionView header.  Perhaps due to this, in some situations the CSHVC.view
traitCollections appear to be UIUserInterfaceSizeClassUnspecified.  Instead
use CSHVC directly.

Bug:  869262 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ide7b1ecea10f056ef83004055122a91e08fd2fd9
Reviewed-on: https://chromium-review.googlesource.com/1196966
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588018}(cherry picked from commit 135ca470f325795782d8fce531716d93399ba9e8)
Reviewed-on: https://chromium-review.googlesource.com/1204933
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#34}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/f3712d6c683140cc585b6694ffc18b85cc40c9b6/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm

Labels: -Merge-Merged-70
Status: Verified (was: Fixed)
Verified on chrome beta version 70.0.3538.13 on iPad Mini with iOS 11.4.1 following steps mentioned in comment #0.  Text color is normal and looks good. 

Sign in to add a comment