New issue
Advanced search Search tips

Issue 869258 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 868248
Owner:
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: ----
Type: ----



Sign in to add a comment

Compile failing on "Google Chrome Win" due to comparison of integers of different signs

Project Member Reported by patricia...@chromium.org, Jul 31

Issue description

Tree is closed (Automatic: "compile" on https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/34622 "Google Chrome Win" from 1f75f99ff2f94234223b089297b66ecd791906ee: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,tikuta@chromium.org)

Google Chrome Win builder is failing compile due to the following error:

../../chrome/browser/conflicts/incompatible_applications_updater_win.cc(289,32):  error: comparison of integers of different signs: 'int' and 'std::vector<IncompatibleApplicationsUpdater::ModuleWarningDecision, std::allocator<IncompatibleApplicationsUpdater::ModuleWarningDecision> >::size_type' (aka 'unsigned int') [-Werror,-Wsign-compare]
  if (module_key.module_id + 1 > module_warning_decisions_.size())
      ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Caused by the following commit: https://chromium-review.googlesource.com/c/chromium/src/+/1152840

Probably the fix is to update https://cs.chromium.org/chromium/src/chrome/browser/conflicts/module_info_win.h?rcl=1f75f99ff2f94234223b089297b66ecd791906ee&l=18 to size_t instead of int?

Reverting crrev.com/c/1152840 for now.
 
Summary: Compile failing on "Google Chrome Win" due to comparison of integers of different signs (was: Compile failing on "" due to comparison of integers of different signs )
See revert at crrev.com/c/1156144
Mergedinto: 868248
Status: Duplicate (was: Assigned)

Sign in to add a comment