Remove constructed_tree_scopes from CSSStyleSheet |
||
Issue descriptionPreviously the field constructed_tree_scopes is added to CSSStyleSheet to track addition of constructed CSSStyleSheets in tree scopes when adding/removing them from TreeScope.moreStyleSheets. As the draft spec has moved away from moreStyleSheets, we want to remove constructed_tree_scopes. https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/css_style_sheet.h?sq=package:chromium&g=0&l=233 See draft spec at: https://github.com/WICG/construct-stylesheets
,
Jul 31
@ above Sorry, I'm working on this already.
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b10abf0f91e61eb30e80d0b78c1dea2c0c6b50c commit 3b10abf0f91e61eb30e80d0b78c1dea2c0c6b50c Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Tue Jul 31 05:41:17 2018 Remove constructed_tree_scopes from CSSStyleSheet Previously the field constructed_tree_scopes is added to CSSStyleSheet to track addition of constructed CSSStyleSheets in tree scopes when adding/removing them from TreeScope.moreStyleSheets. moreStyleSheets already was removed at blink[1]. so constructed_tree_scopes is not needed anymore. [1]https://chromium-review.googlesource.com/1125741 Bug: 869244 Change-Id: Icc0b68393fd100d08ee826d6dbe0859468ee1e23 Reviewed-on: https://chromium-review.googlesource.com/1155286 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#579321} [modify] https://crrev.com/3b10abf0f91e61eb30e80d0b78c1dea2c0c6b50c/third_party/blink/renderer/core/css/css_style_sheet.cc [modify] https://crrev.com/3b10abf0f91e61eb30e80d0b78c1dea2c0c6b50c/third_party/blink/renderer/core/css/css_style_sheet.h
,
Jul 31
@momon sorry. i didn't see the your comment :(.
,
Jul 31
@hs1217.lee All is well, my fault for not assigning the bug yet. Thank you for contributing quickly though :D |
||
►
Sign in to add a comment |
||
Comment 1 by hs1217....@samsung.com
, Jul 31