New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 31
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Compile failing on "Mac Builder" due to missing dependency in chrome/browser/web_applications/components/BUILD.gn

Project Member Reported by patricia...@chromium.org, Jul 31

Issue description

Tree is closed (Automatic: "compile" on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20Builder/89218 "Mac Builder" from 94b94be19fba32eedb72590a411fb507e473c5b5: michaeldo@chromium.org,hcarmona@chromium.org,edchin@chromium.org,sczs@chromium.org,bajones@chromium.org,jinsukkim@chromium.org,ntfschr@chromium.org,pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,dalecurtis@chromium.org,pbos@chromium.org,etienneb@chromium.org,ericrk@chromium.org,imcheng@ch…

Mac Builder is failing compile due to the following error:

../../chrome/browser/web_applications/components/web_app_shortcut_mac_unittest.mm:26:10: fatal error: 'chrome/grit/theme_resources.h' file not found
#include "chrome/grit/theme_resources.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Which was probably triggered by this commit: https://chromium-review.googlesource.com/c/chromium/src/+/1155496

"//chrome/app/theme:theme_resources" probably needs to be added as a dependency to chrome/browser/web_applications/components/BUILD.gn. For now, will reopen the tree as this failure is probably flaky.

Thanks!
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4587520402ff065a2f3fff69842513d3017bb05d

commit 4587520402ff065a2f3fff69842513d3017bb05d
Author: Alexey Baskakov <loyso@chromium.org>
Date: Tue Jul 31 03:11:01 2018

WebApp: Add missing dependency.

TBR=tapted@chromium.org

Bug:  869241 
Change-Id: I932f8c321839a21dda61285df3f8a5f5856ac9ea
Reviewed-on: https://chromium-review.googlesource.com/1155278
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579301}
[modify] https://crrev.com/4587520402ff065a2f3fff69842513d3017bb05d/chrome/browser/web_applications/components/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment