New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869232 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

owners.py: per-file seems NOT to be recursive

Project Member Reported by m...@chromium.org, Jul 31

Issue description

Recently, we started seeing duplicated "per-file" rules sprinkled in the OWNERS files in child directories. Mainly, these have been getting added out of necessity. Example: https://chromium-review.googlesource.com/c/chromium/src/+/1150815

Strangely, crbug 643390 seems to indicate that it may actually behave this way in some situations. It's not clear why that is.

So, after an offline discussion with several owners and the build infra folks, there was a question as to whether "per-file" rules *should* be recursive. It turns out that, yes, we do want this behavior.

Comment from dpranke:

"It shouldn't be too hard to do so, but it's not trivial, it requires restructuring the existing implementation to look at the tree as a whole rather than just the files in the directory. It's all just changes in a couple of methods in one python class, though."

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2ac1b645749e574eb733a899b8a106a85c73fcb

commit e2ac1b645749e574eb733a899b8a106a85c73fcb
Author: Yuri Wiitala <miu@chromium.org>
Date: Tue Jul 31 01:07:04 2018

Allow trivial BUILD.gn changes to content/browser/BULID.gn.

Reduce thrash on content/browser/OWNERS and content/renderer/OWNERS for
trivial adds/deletes from the BUILD.gn file. All of content/OWNERS,
chrome/browser/OWNERS, and chrome/renderer/OWNERS already has this, so
there is precedent.

BUG=869232

Change-Id: I535294fd904da1739fa7abb95ce18da162eb42bb
Reviewed-on: https://chromium-review.googlesource.com/1150815
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579272}
[modify] https://crrev.com/e2ac1b645749e574eb733a899b8a106a85c73fcb/content/browser/OWNERS
[modify] https://crrev.com/e2ac1b645749e574eb733a899b8a106a85c73fcb/content/renderer/OWNERS

Sign in to add a comment