generate_build_files failing on multiple builders |
||
Issue descriptionBuilders failed on: - Android Cronet Builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20Cronet%20Builder - Android Cronet Lollipop Builder: https://ci.chromium.org/buildbot/chromium.android/Android%20Cronet%20Lollipop%20Builder --- From the generate_build_files step: ERROR at //chrome/android/chrome_public_apk_tmpl.gni:201:27: Assignment had no effect. proguard_jar_path = "//third_party/proguard/lib/proguard.6.0.3.jar" ^---------------------------------------------- You set the variable "proguard_jar_path" here and it was unused before it went out of scope. See //chrome/android/chrome_public_apk_tmpl.gni:50:3: whence it was called. target(_target_type, target_name) { ^---------------------------------- See //chrome/android/chrome_public_apk_tmpl.gni:137:3: whence it was called. chrome_public_apk_tmpl(target_name) { ^------------------------------------ See //chrome/android/BUILD.gn:1314:3: whence it was called. monochrome_public_apk_tmpl(target_name) { ^---------------------------------------- See //chrome/android/BUILD.gn:1354:1: whence it was called. monochrome_public_apk_or_module_tmpl("monochrome_public_base_module") { ^---------------------------------------------------------------------- See //BUILD.gn:329:9: which caused the file to be included. "//chrome/android:chrome_junit_tests", ^------------------------------------ GN gen failed: 1 step returned non-zero exit code: 1
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb3a9711abe92f1e08611430bd619fd9ff20628e commit fb3a9711abe92f1e08611430bd619fd9ff20628e Author: Nate Fischer <ntfschr@chromium.org> Date: Tue Jul 31 00:44:37 2018 Revert "Use proguard version 6.0.3 for monochrome_public_apk." This reverts commit df22b81425e5487282a2569f9fd274300a43e3e5. Reason for revert: breaks generate_build_files ( http://crbug.com/869231 ) Original change's description: > Use proguard version 6.0.3 for monochrome_public_apk. > > MonochromePublic.apk release builds are very close to the main dex limit > and updating proguard reduces the number of methods by about 3000. > > 6.0.3 cannot be used for all APKs yet due to a bug which causes > cronet_test_instrumentation_apk to fail. > > The version mismatch should be temporary as we plan to switch to R8 in the > future ( https://crbug.com/868770 ). > > Bug: 857572 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester > Change-Id: I3676a42908c5046dc3f3831e282150702038140d > Reviewed-on: https://chromium-review.googlesource.com/1154366 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579250} TBR=yfriedman@chromium.org,estevenson@chromium.org Change-Id: I1d7e50cf720e9a128a62f06bb34a4c9f6d25c60d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 857572 Bug: 869231 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/1155502 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579262} [modify] https://crrev.com/fb3a9711abe92f1e08611430bd619fd9ff20628e/build/config/android/rules.gni [modify] https://crrev.com/fb3a9711abe92f1e08611430bd619fd9ff20628e/chrome/android/chrome_public_apk_tmpl.gni [modify] https://crrev.com/fb3a9711abe92f1e08611430bd619fd9ff20628e/third_party/proguard/README.chromium [delete] https://crrev.com/96e79bafa83371ce5e334dec900712439990b8a2/third_party/proguard/lib/proguard.6.0.3.jar
,
Jul 31
Thanks for reverting! Definitely the culprit.
,
Jul 31
For the record, the reason why the CL brok the build is because there is a missing variable forward for proguard_jar_path. This is addressed by https://chromium-review.googlesource.com/c/chromium/src/+/1154979 which I hope to land very soon. |
||
►
Sign in to add a comment |
||
Comment 1 by ntfschr@chromium.org
, Jul 31Status: Assigned (was: Untriaged)