New issue
Advanced search Search tips

Issue 869223 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

IPP-over-USB Broken in R69-10739.0.0 (and later)

Project Member Reported by valleau@chromium.org, Jul 31

Issue description

What steps will reproduce the problem?
(1) Attempt to setup an IPP-over-USB printer

What is the expected result?

The printer will be added successfully

What happens instead?

The dialog to select the make and model of the printer is surfaced, indicating that we were not able to setup the printer automatically.



 
I've identified the CL which caused this issue:

https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1053426

The directory "/run/ippusb" which contains the socket used for ippusb printing is not being mounted. I have tested a change which mounts this path as well and it fixes the issue.
Cc: ka...@chromium.org
Labels: ReleaseBlock-Stable M-69
+kalin@ - FYI. We're working on getting a more automated test in place for this, but wanted to make sure your team is aware in the meantime.
Does it happen with any USB connected printer, and any of the cros platforms?

Should also print dialog for auto-discovered USB printers be affected?
Cc: sontis@chromium.org pgangishetty@chromium.org matthewjoseph@chromium.org
kalin@ - This is specific to the IPP over USB workflow (not all USB connected printers).
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e694deb429ac85bd0bfbb9f1454b03927809b480

commit e694deb429ac85bd0bfbb9f1454b03927809b480
Author: David Valleau <valleau@chromium.org>
Date: Wed Aug 01 21:52:29 2018

debugd: Adding /run/ippusb to the mount namespace

Since /run/ippusb was not included in the mount namespace, ipp-over-usb
printing was failing as debugd is unable to access the socket found in
the directory.

BUG= chromium:869223 
TEST=Tested manually on device

Change-Id: Ib1e2fbbb0892e798929aad29626df78eb95d52c9
Reviewed-on: https://chromium-review.googlesource.com/1155968
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e694deb429ac85bd0bfbb9f1454b03927809b480/debugd/src/main.cc

Labels: Merge-Request-69
Status: Fixed (was: Assigned)
I have tested that these changes on one of the latest images (R70-10944.0.0) from Goldeneye and everything works correctly.

If possible I would like to have them picked back into M69 as they fix crashes that users would experience when trying to print. These are small changes that should not have an impact on any other systems.
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 6

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 9

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fcf4ee1e3614bb8fca1f5dd2c19326d1c56e7e1a

commit fcf4ee1e3614bb8fca1f5dd2c19326d1c56e7e1a
Author: David Valleau <valleau@chromium.org>
Date: Thu Aug 09 22:33:21 2018

debugd: Adding /run/ippusb to the mount namespace

Since /run/ippusb was not included in the mount namespace, ipp-over-usb
printing was failing as debugd is unable to access the socket found in
the directory.

BUG= chromium:869223 
TEST=Tested manually on device

Change-Id: Ib1e2fbbb0892e798929aad29626df78eb95d52c9
Reviewed-on: https://chromium-review.googlesource.com/1155968
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit e694deb429ac85bd0bfbb9f1454b03927809b480)
Reviewed-on: https://chromium-review.googlesource.com/1169924
Commit-Queue: David Valleau <valleau@chromium.org>

[modify] https://crrev.com/fcf4ee1e3614bb8fca1f5dd2c19326d1c56e7e1a/debugd/src/main.cc

Project Member

Comment 11 by sheriffbot@chromium.org, Aug 13

Cc: cindyb@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-69

Sign in to add a comment