Put DocumentProvider Scoring Under Finch Control |
||||||
Issue descriptionDocument (Drive) provider should have Finch controls for scoring and min-character settings.
,
Aug 2
,
Aug 2
,
Aug 2
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
Is the change well baked/verified in canary and overall safe to merge to M69? Also could you pls justify the merge. Thank you.
,
Aug 2
Rationale - moves some constants to finch scoring params so we can control omnibox scoring results at a finer grain after launch. It's safe and contained, and behind a flag, but the API that this code exercises isn't quite public yet so it's been unexercised by end users and will continue to be until that ships (very soon) and we can enable via finch.
,
Aug 2
Approving merge to M69 branch 3497 based on comment #6. Please merge ASAP.
,
Aug 5
Please merge your change to M69 branch 3497 by 4:00 PM PT, Monday (08/06) so we can pick it up for next week M69 beta release. Thank you.
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5 commit 2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5 Author: Travis Skare <skare@chromium.org> Date: Mon Aug 06 14:55:59 2018 Make DocumentProvider scoring params configurable by study. Bug: 864302 , 869221 Change-Id: I29318c89757dbf21ace69a83519d62d237691f2c Reviewed-on: https://chromium-review.googlesource.com/1139404 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579905}(cherry picked from commit da23ca67d17abaaf71b3a87b7589f003b0fefcdc) Reviewed-on: https://chromium-review.googlesource.com/1162523 Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#416} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5/components/omnibox/browser/document_provider.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 1