New issue
Advanced search Search tips

Issue 869221 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Put DocumentProvider Scoring Under Finch Control

Project Member Reported by skare@chromium.org, Jul 31

Issue description

Document (Drive) provider should have Finch controls for scoring and min-character settings.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da23ca67d17abaaf71b3a87b7589f003b0fefcdc

commit da23ca67d17abaaf71b3a87b7589f003b0fefcdc
Author: Travis Skare <skare@chromium.org>
Date: Wed Aug 01 19:49:52 2018

Make DocumentProvider scoring params configurable by study.

Bug:  864302 ,  869221 
Change-Id: I29318c89757dbf21ace69a83519d62d237691f2c
Reviewed-on: https://chromium-review.googlesource.com/1139404
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579905}
[modify] https://crrev.com/da23ca67d17abaaf71b3a87b7589f003b0fefcdc/components/omnibox/browser/document_provider.cc

Labels: M-69 OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Started)
Labels: Merge-Request-69
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 2

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Is the change well baked/verified in canary and overall safe to merge to M69? Also could you pls justify the merge. Thank you.
Rationale - moves some constants to finch scoring params so we can control omnibox scoring results at a finer grain after launch.
 
It's safe and contained, and behind a flag, but the API that this code exercises isn't quite public yet so it's been unexercised by end users and will continue to be until that ships (very soon) and we can enable via finch.

Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #6. Please merge ASAP. 
Please merge your change to M69 branch 3497 by 4:00 PM PT, Monday (08/06) so we can pick it up for next week M69 beta release. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 6

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5

commit 2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5
Author: Travis Skare <skare@chromium.org>
Date: Mon Aug 06 14:55:59 2018

Make DocumentProvider scoring params configurable by study.

Bug:  864302 ,  869221 
Change-Id: I29318c89757dbf21ace69a83519d62d237691f2c
Reviewed-on: https://chromium-review.googlesource.com/1139404
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579905}(cherry picked from commit da23ca67d17abaaf71b3a87b7589f003b0fefcdc)
Reviewed-on: https://chromium-review.googlesource.com/1162523
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#416}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2c3fd1eacd84cf6024ab2ec1da2385997c16d6c5/components/omnibox/browser/document_provider.cc

Sign in to add a comment