New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 869209 link

Starred by 2 users
Status: Verified
Owner:
zentaro@chromium.org
Closed: Nov 12
Cc:
█ hunyadym@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add build infra for rollback save and restore

Project Member Reported by zentaro@chromium.org, Jul 30 
Add users, ebuilds and code stubs for a rollback_save and rollback_restore utility.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/118a196470df5f9e7fe360899c12c90e86eb7a2c

commit 118a196470df5f9e7fe360899c12c90e86eb7a2c
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 01 21:52:25 2018

oobe_config: Add skeleton of oobe_config utilities

- Adds a oobe_config_save and oobe_config_restore
  executable
- Adds a liboobeconfig library
- Adds a test file

BUG= chromium:869209 
TEST=emerges and tests pass

Change-Id: Ia4faaf4b3817893afcfb37d06b4af9f8c2259706
Reviewed-on: https://chromium-review.googlesource.com/1155943
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>

[add] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/oobe_config/oobe_config_test.cc
[add] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/oobe_config/oobe_config.h
[add] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/oobe_config/OWNERS
[add] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/oobe_config/oobe_config.gyp
[add] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/oobe_config/README.md
[add] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/oobe_config/oobe_config_restore_main.cc
[add] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/oobe_config/oobe_config.cc
[modify] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/README.md
[add] https://crrev.com/118a196470df5f9e7fe360899c12c90e86eb7a2c/oobe_config/oobe_config_save_main.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/6ba25135807373ef8a76e23bbe372aa2339741a7

commit 6ba25135807373ef8a76e23bbe372aa2339741a7
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:47 2018

Add oobe_config to PRESUMBIT.cfg

BUG= chromium:869209 
TEST=no format errors

Change-Id: I29496740a3eaa6fae4b2f9f52babbe9ee2fd473f
Reviewed-on: https://chromium-review.googlesource.com/1165625
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/6ba25135807373ef8a76e23bbe372aa2339741a7/PRESUBMIT.cfg
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a346121e349961547eab497f3531855d72d107d0

commit a346121e349961547eab497f3531855d72d107d0
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 04:44:48 2018

oobe_config: Post submit review comments on 1155943

BUG= chromium:869209 
TEST=unittests

Change-Id: I0fecdc82aa10464934bedfd401c483f21f43172b
Reviewed-on: https://chromium-review.googlesource.com/1165785
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a346121e349961547eab497f3531855d72d107d0/oobe_config/oobe_config.gyp
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/966019d99d96e86d378537bfc7e853f73113b8a3

commit 966019d99d96e86d378537bfc7e853f73113b8a3
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Aug 08 17:24:56 2018

oobe_config: Add ebuild for oobe_config executables

- Adds basic build file for oobe_config_save and
  oobe_config_restore executables
- Adds the user setup for the two users

CQ-DEPEND=CL:1155928
CQ-DEPEND=CL:1155943

BUG= chromium:869209 
TEST=emerges

Change-Id: I4c5256fe369bfd68e88d6ebec49df19cbbeed29f
Reviewed-on: https://chromium-review.googlesource.com/1155979
Commit-Ready: Marton Hunyady <hunyadym@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/966019d99d96e86d378537bfc7e853f73113b8a3/chromeos-base/chromeos-chrome/metadata.xml
[modify] https://crrev.com/966019d99d96e86d378537bfc7e853f73113b8a3/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[add] https://crrev.com/966019d99d96e86d378537bfc7e853f73113b8a3/chromeos-base/oobe_config/oobe_config-9999.ebuild
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/59d1ebfee8356bafacfae650c1ce593431f2bc5f

commit 59d1ebfee8356bafacfae650c1ce593431f2bc5f
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Aug 23 20:20:47 2018

oobe_config: Add upstart .conf file

- Wraps daemon in minijail
- Does not have any start or stop signals yet
- Does not have secomp filters yet

BUG= chromium:869209 
TEST=None

Change-Id: I5e2bd5dbae3ef1bb11e13b9af12994f5f6c65ea6
Reviewed-on: https://chromium-review.googlesource.com/1168519
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/59d1ebfee8356bafacfae650c1ce593431f2bc5f/oobe_config/etc/init/oobe_config_restore.conf
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1ef4693f24823dc84746903521f585cd3dcc1d15

commit 1ef4693f24823dc84746903521f585cd3dcc1d15
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Sep 08 05:27:33 2018

oobe_config: Add initial DBUS config

BUG= chromium:869209 
TEST=emerges

Change-Id: If8ad30abdf3e8c9bce687af57efcf8e1d55c7ec3
Reviewed-on: https://chromium-review.googlesource.com/1168521
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>

[add] https://crrev.com/1ef4693f24823dc84746903521f585cd3dcc1d15/oobe_config/etc/dbus-1/org.chromium.OobeConfigRestore.conf
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e0d0d33ea648feba145c8483ece317b6845a074d

commit e0d0d33ea648feba145c8483ece317b6845a074d
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sun Sep 09 02:06:34 2018

oobe_config: Add the DBUS service implementation class.

BUG= chromium:869209 
TEST=emerges

Change-Id: Idf9478ad8bc393ae2cf84a1766a1c106675e822b
Reviewed-on: https://chromium-review.googlesource.com/1205132
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/e0d0d33ea648feba145c8483ece317b6845a074d/oobe_config/oobe_config_restore_service.cc
[modify] https://crrev.com/e0d0d33ea648feba145c8483ece317b6845a074d/oobe_config/oobe_config.gyp
[add] https://crrev.com/e0d0d33ea648feba145c8483ece317b6845a074d/oobe_config/oobe_config_restore_service.h
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3604ecc00951fa1862bd9db717a8d3604a244348

commit 3604ecc00951fa1862bd9db717a8d3604a244348
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Mon Sep 10 00:51:14 2018

chromeos-base/oobe_config: Add upstart conf files

CQ-DEPEND=CL:1168519
CQ-DEPEND=CL:1168521

BUG= chromium:869209 
TEST=emerges

Change-Id: I061a45b5ec22b6a089332199e7aa4c9ca2527a06
Reviewed-on: https://chromium-review.googlesource.com/1168585
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>

[modify] https://crrev.com/3604ecc00951fa1862bd9db717a8d3604a244348/chromeos-base/oobe_config/oobe_config-9999.ebuild
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75f908e623379a73151f13ef2d343769b3f11e5a

commit 75f908e623379a73151f13ef2d343769b3f11e5a
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Tue Sep 11 18:24:19 2018

Roll src/third_party/cros_system_api/ 41fa30110..326384d6d (2 commits)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/41fa30110678..326384d6d8ea

$ git log 41fa30110..326384d6d --date=short --no-merges --format='%ad %ae %s'
2018-08-30 zentaro system_api: Add DBus constants and protos for OOBE config
2018-08-30 mqg login: Add retrieve primary user to session manager dbus constants

Created with:
  roll-dep src/third_party/cros_system_api

Bug:  869209 
Change-Id: I8cb18805e20047ddc8a34d28ed244997ef76f473
Reviewed-on: https://chromium-review.googlesource.com/1220028
Reviewed-by: May Lippert <maybelle@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590411}
[modify] https://crrev.com/75f908e623379a73151f13ef2d343769b3f11e5a/DEPS
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f118f31ee04f7cdaf925cedbcd192bd676116534

commit f118f31ee04f7cdaf925cedbcd192bd676116534
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Sep 13 18:07:02 2018

oobe_config: Add DBUS daemon code

BUG= chromium:869209 
TEST=emerges

Change-Id: I3d1febb0b65c3b68c23c49a7d9fa94dd5f7c2a17
Reviewed-on: https://chromium-review.googlesource.com/1205133
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>

[modify] https://crrev.com/f118f31ee04f7cdaf925cedbcd192bd676116534/oobe_config/oobe_config_restore_main.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/52d19e44884c3396a7b46d5244aa06efae375122

commit 52d19e44884c3396a7b46d5244aa06efae375122
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Sep 22 15:30:02 2018

system_api: Include oobe_config to build

BUG= chromium:869209 
TEST=emerges

Change-Id: I9d312f42112a870df399073fc90df7110491c3fd
Reviewed-on: https://chromium-review.googlesource.com/1238633
Commit-Ready: Marton Hunyady <hunyadym@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/52d19e44884c3396a7b46d5244aa06efae375122/chromeos-base/system_api/system_api-9999.ebuild
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f9f4039e36a72a6af88f09c2ba4572303747f771

commit f9f4039e36a72a6af88f09c2ba4572303747f771
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Sat Sep 22 15:30:03 2018

oobe_config: Return a valid but empty proto

- Makes it possible to call the function without failing

CQ-DEPEND=CL:1238633
BUG= chromium:869209 
TEST=emerges

Change-Id: Id25160060000de6075d1f7db2f35beb36f19a369
Reviewed-on: https://chromium-review.googlesource.com/1231215
Commit-Ready: Marton Hunyady <hunyadym@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/f9f4039e36a72a6af88f09c2ba4572303747f771/oobe_config/oobe_config_restore_service.cc
[modify] https://crrev.com/f9f4039e36a72a6af88f09c2ba4572303747f771/oobe_config/oobe_config.gyp
[modify] https://crrev.com/f9f4039e36a72a6af88f09c2ba4572303747f771/oobe_config/oobe_config_restore_service.h

Comment 16 by zentaro@chromium.org, Nov 12

Status: Fixed (was: Started)

Comment 17 by vaandres@google.com, Nov 16 

is there any need for manual verification?

Comment 18 by zentaro@chromium.org, Nov 16 

This one doesn't need explicit testing.

Comment 19 by vaandres@google.com, Nov 16 

excellent. Do you mind changing the status to verified ? Thanks

Comment 20 by vaandres@google.com, Nov 20

Labels: Needs-Feedback

Comment 21 by zentaro@chromium.org, Nov 20

Status: Verified (was: Fixed)
►

Sign in to add a comment