New issue
Advanced search Search tips

Issue 869206 link

Starred by 1 user
Status: Fixed
Owner:
spang@chromium.org
Closed: Aug 7
Cc:
dnicoara@chromium.org
msi...@igalia.com
rjkroege@chromium.org
dcasta...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

clean up DRM buffer types to facilitate code sharing with wayland

Project Member Reported by spang@chromium.org, Jul 30 
We also have a rather confusing pair of buffer classes that are nearly the same thing - GbmBuffer and GbmPixmap.

We could split things out as follows:
  - GbmBuffer wraps a gbm_bo and contains no DRM master specifics
  - GbmPixmap owns a GbmBuffer and adds the presentation parts
    (i.e. adding framebuffers to DRM, and scheduling them with the page flip)

Removing the DRM-master bits from GbmBuffer would also mean we can move it to //ui/ozone/common/ and share it with wayland.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/719b0f532adbca569a363efdb18aaa5ab6385b3e

commit 719b0f532adbca569a363efdb18aaa5ab6385b3e
Author: Michael Spang <spang@chromium.org>
Date: Tue Jul 31 18:21:19 2018

ozone: drm: Switch back to using DrmDevice directly

Since these types were moved back to DRM, we can use DrmDevice* instead
of GbmDeviceLinux* again.

Bug:  869206 
Test: compile

Change-Id: I61d69e16c4e8d93f5bc913698ee0fab410c3db2e
Reviewed-on: https://chromium-review.googlesource.com/1155909
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579483}
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/drm_buffer.cc
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/drm_buffer.h
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/drm_device.h
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/gbm_buffer.cc
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/gbm_buffer.h
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/mock_scanout_buffer.cc
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/mock_scanout_buffer.h
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/scanout_buffer.h
[modify] https://crrev.com/719b0f532adbca569a363efdb18aaa5ab6385b3e/ui/ozone/platform/drm/gpu/screen_manager.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853

commit 55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853
Author: Michael Spang <spang@chromium.org>
Date: Tue Jul 31 18:54:22 2018

ozone: drm: Inline RequiresGlFinish()

No functional change. This is needed prior to some refactoring.

Bug:  869206 

Change-Id: I2db96c903b64b50ac8e33739263cdbb0297bde2f
Reviewed-on: https://chromium-review.googlesource.com/1155910
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579503}
[modify] https://crrev.com/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853/ui/ozone/platform/drm/gpu/drm_buffer.cc
[modify] https://crrev.com/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853/ui/ozone/platform/drm/gpu/drm_buffer.h
[modify] https://crrev.com/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853/ui/ozone/platform/drm/gpu/gbm_buffer.cc
[modify] https://crrev.com/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853/ui/ozone/platform/drm/gpu/gbm_buffer.h
[modify] https://crrev.com/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
[modify] https://crrev.com/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853/ui/ozone/platform/drm/gpu/mock_scanout_buffer.cc
[modify] https://crrev.com/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853/ui/ozone/platform/drm/gpu/mock_scanout_buffer.h
[modify] https://crrev.com/55c9911d60d38c9f6f43c0dc66f54d7c3b5b2853/ui/ozone/platform/drm/gpu/scanout_buffer.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47cdc66ba29174d2a355f7b9d5152171f518cda5

commit 47cdc66ba29174d2a355f7b9d5152171f518cda5
Author: Michael Spang <spang@chromium.org>
Date: Tue Jul 31 19:45:31 2018

ozone: drm: Use DrmBuffer instead of ScanoutBuffer for cursors

Use the concrete type of the dumb buffer for cursors. We don't need
polymorphism here, and since cursors don't have framebuffers, this is
needed before evolving ScanoutBuffer into a concrete framebuffer type.

Bug:  869206 

Change-Id: I5ee8162cd103d55df320cbc8e35be29e9ac15562
Reviewed-on: https://chromium-review.googlesource.com/1155911
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579535}
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/crtc_controller.cc
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/crtc_controller.h
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/drm_buffer.cc
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/drm_buffer.h
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/gbm_buffer.cc
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/gbm_buffer.h
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/hardware_display_controller.h
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/mock_scanout_buffer.cc
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/mock_scanout_buffer.h
[modify] https://crrev.com/47cdc66ba29174d2a355f7b9d5152171f518cda5/ui/ozone/platform/drm/gpu/scanout_buffer.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90c40887181fcfd72fa1b0b7ecc4a510623d7c54

commit 90c40887181fcfd72fa1b0b7ecc4a510623d7c54
Author: Michael Spang <spang@chromium.org>
Date: Tue Jul 31 21:08:36 2018

ozone: drm: Rename ScanoutBuffer to DrmFramebuffer

ScanoutBuffer is used to wrap a framebuffer, so call it that.

Bug:  869206 

Change-Id: Idf748e60b4bbaed774cd91e9c3d35cb3778bae26
Reviewed-on: https://chromium-review.googlesource.com/1155912
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579569}
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/crtc_controller.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_buffer.h
[rename] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_framebuffer.h
[rename] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_framebuffer_generator.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_overlay_plane.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_overlay_plane.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_overlay_validator.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_overlay_validator.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_window.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_window_proxy.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/drm_window_unittest.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/gbm_buffer.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/hardware_display_controller.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc
[add] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/mock_drm_framebuffer.cc
[rename] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/mock_drm_framebuffer.h
[add] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/mock_drm_framebuffer_generator.cc
[add] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/mock_drm_framebuffer_generator.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.h
[delete] https://crrev.com/428a076ac891ae6cb0d5374ba26904557593ccdb/ui/ozone/platform/drm/gpu/mock_scanout_buffer.cc
[delete] https://crrev.com/428a076ac891ae6cb0d5374ba26904557593ccdb/ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.cc
[delete] https://crrev.com/428a076ac891ae6cb0d5374ba26904557593ccdb/ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/screen_manager.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/screen_manager.h
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/gpu/screen_manager_unittest.cc
[modify] https://crrev.com/90c40887181fcfd72fa1b0b7ecc4a510623d7c54/ui/ozone/platform/drm/ozone_platform_gbm.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e03a11646747ae389fb6a20146c0259b9c1704f9

commit e03a11646747ae389fb6a20146c0259b9c1704f9
Author: Michael Spang <spang@chromium.org>
Date: Tue Jul 31 21:54:26 2018

ozone: drm: Inline MockDrmFramebuffer into MockDrmFramebufferGenerator

Prepare for removing mock framebuffers by moving the class into
MockDrmFramebufferGenerator. We don't need a mock framebuffer type.

Bug:  869206 

Change-Id: I8a909d385f455fde0776e3cf5ad8d24791753e23
Reviewed-on: https://chromium-review.googlesource.com/1155913
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579586}
[modify] https://crrev.com/e03a11646747ae389fb6a20146c0259b9c1704f9/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/e03a11646747ae389fb6a20146c0259b9c1704f9/ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc
[modify] https://crrev.com/e03a11646747ae389fb6a20146c0259b9c1704f9/ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc
[modify] https://crrev.com/e03a11646747ae389fb6a20146c0259b9c1704f9/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc
[delete] https://crrev.com/6da188f94a6ff5dfe7cde7869184d5e7d1dc4a4a/ui/ozone/platform/drm/gpu/mock_drm_framebuffer.cc
[delete] https://crrev.com/6da188f94a6ff5dfe7cde7869184d5e7d1dc4a4a/ui/ozone/platform/drm/gpu/mock_drm_framebuffer.h
[modify] https://crrev.com/e03a11646747ae389fb6a20146c0259b9c1704f9/ui/ozone/platform/drm/gpu/mock_drm_framebuffer_generator.cc

Comment 6 by spang@chromium.org, Jul 31 

ozone: drm: Move cursor buffer management to HardwareDisplayController

Since HardwareDisplayControllers are never moved between DRM devices,
it's much simpler to manage the cursor buffers there - we never need to
reallocate them due to a device change. This will also allow us to remove
the refcounting.

Bug: 868010

Change-Id: Ie7e3615b4c653ea6250a4a4a45510c84badabe9c
Reviewed-on: https://chromium-review.googlesource.com/1155915
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579593}

Comment 7 by spang@chromium.org, Jul 31 

ozone: drm: Concretize DrmFramebuffer and compose it into {Gbm,Drm}Buffer

Change DrmFramebuffer from a virtual interface to a concrete wrapper for
a DRM framebuffer. This is what used to be ScanoutBuffer and is all that
is needed for modesetting. In particular, we don't need access to gbm_bo,
skia surfaces backed by dumb buffer mmaps, or other bits from
{Gbm,Drm}Buffer in the modesetting internals.

DrmFramebuffer is composed into GbmBuffer and DrmBuffer so that we can
still access framebuffers for those types when presenting a buffer.
GbmBuffer and DrmBuffer are no longer refcounted after this change.

Bug: 868010

Change-Id: I6d31b000b35bc4a6caa6280bee4156ca9b271bb9
Reviewed-on: https://chromium-review.googlesource.com/1155916
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579605}
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3c77889f749d8fedc92442f12d8a9a3aac060f3

commit d3c77889f749d8fedc92442f12d8a9a3aac060f3
Author: Michael Spang <spang@chromium.org>
Date: Wed Aug 01 00:04:30 2018

ozone: drm: Simplify buffer allocation

Move the giant buffer usage conversion switch/case out of line. Move all
of the possible ways modifiers will not be used into one condition.
Rather than using a loop for retrying allocation without
GBM_BO_USE_SCANOUT, move the inner part into a function and call it
again.

Bug:  869206 

Change-Id: I8d5b36a56bab8667077391c573e1d0b82f91d25f
Reviewed-on: https://chromium-review.googlesource.com/1155917
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579628}
[modify] https://crrev.com/d3c77889f749d8fedc92442f12d8a9a3aac060f3/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/d3c77889f749d8fedc92442f12d8a9a3aac060f3/ui/ozone/platform/drm/gpu/gbm_buffer.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fc38604ad7726ba4610867da0ec818565e103f2

commit 6fc38604ad7726ba4610867da0ec818565e103f2
Author: Michael Spang <spang@chromium.org>
Date: Wed Aug 01 01:24:05 2018

ozone: drm: Move DrmFramebuffer from GbmBuffer to GbmPixmap

Framebuffers are a DRM-master specific object, so move them out out of
GbmBuffer. This makes GbmBuffer independent enough of the DRM modesetting
code that we can merge it with GbmBoWrapper.

Bug:  869206 

Change-Id: I4ae6e1191ef115a4aa58b1c7ccb9f19e06de28aa
Reviewed-on: https://chromium-review.googlesource.com/1155918
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579656}
[modify] https://crrev.com/6fc38604ad7726ba4610867da0ec818565e103f2/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/6fc38604ad7726ba4610867da0ec818565e103f2/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/6fc38604ad7726ba4610867da0ec818565e103f2/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/6fc38604ad7726ba4610867da0ec818565e103f2/ui/ozone/platform/drm/gpu/drm_thread_proxy.h
[modify] https://crrev.com/6fc38604ad7726ba4610867da0ec818565e103f2/ui/ozone/platform/drm/gpu/gbm_buffer.cc
[modify] https://crrev.com/6fc38604ad7726ba4610867da0ec818565e103f2/ui/ozone/platform/drm/gpu/gbm_buffer.h
[modify] https://crrev.com/6fc38604ad7726ba4610867da0ec818565e103f2/ui/ozone/platform/drm/gpu/gbm_overlay_surface.cc
[modify] https://crrev.com/6fc38604ad7726ba4610867da0ec818565e103f2/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f074a0649cc1ad4cab8745882a8dc4eb0d3b394

commit 3f074a0649cc1ad4cab8745882a8dc4eb0d3b394
Author: Michael Spang <spang@chromium.org>
Date: Wed Aug 01 04:56:07 2018

ozone: drm: Merge GbmBuffer and GbmBoWrapper together

Since there's no longer any DRM-master specifics in GbmBuffer, move it
to //ui/ozone/common/linux and remove GbmBoWrapper.

Bug:  869206 

Change-Id: I079f157e2f8ad46ea1f68670421d6d700abba25d
Reviewed-on: https://chromium-review.googlesource.com/1155919
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579704}
[modify] https://crrev.com/3f074a0649cc1ad4cab8745882a8dc4eb0d3b394/ui/ozone/common/linux/BUILD.gn
[delete] https://crrev.com/b521e13fad5948567374b6cb7599011f0c481289/ui/ozone/common/linux/gbm_bo_wrapper.cc
[delete] https://crrev.com/b521e13fad5948567374b6cb7599011f0c481289/ui/ozone/common/linux/gbm_bo_wrapper.h
[add] https://crrev.com/3f074a0649cc1ad4cab8745882a8dc4eb0d3b394/ui/ozone/common/linux/gbm_buffer.cc
[add] https://crrev.com/3f074a0649cc1ad4cab8745882a8dc4eb0d3b394/ui/ozone/common/linux/gbm_buffer.h
[modify] https://crrev.com/3f074a0649cc1ad4cab8745882a8dc4eb0d3b394/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/3f074a0649cc1ad4cab8745882a8dc4eb0d3b394/ui/ozone/platform/drm/gpu/gbm_buffer.cc
[modify] https://crrev.com/3f074a0649cc1ad4cab8745882a8dc4eb0d3b394/ui/ozone/platform/drm/gpu/gbm_buffer.h
[modify] https://crrev.com/3f074a0649cc1ad4cab8745882a8dc4eb0d3b394/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46ec55a080af80c330fc5afb7770f16ee25be151

commit 46ec55a080af80c330fc5afb7770f16ee25be151
Author: Michael Spang <spang@chromium.org>
Date: Wed Aug 01 15:57:26 2018

ozone: drm: Rename gbm_buffer.{cc.h} to gbm_pixmap.{cc,h}

Since GbmBuffer moved, the only class this file defines is GbmPixmap. So
rename it.

Bug:  869206 

Change-Id: If58f4590c8a118d557059368617e1521e9f16802
Reviewed-on: https://chromium-review.googlesource.com/1155920
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579822}
[modify] https://crrev.com/46ec55a080af80c330fc5afb7770f16ee25be151/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/46ec55a080af80c330fc5afb7770f16ee25be151/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/46ec55a080af80c330fc5afb7770f16ee25be151/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/46ec55a080af80c330fc5afb7770f16ee25be151/ui/ozone/platform/drm/gpu/gbm_overlay_surface.cc
[rename] https://crrev.com/46ec55a080af80c330fc5afb7770f16ee25be151/ui/ozone/platform/drm/gpu/gbm_pixmap.cc
[rename] https://crrev.com/46ec55a080af80c330fc5afb7770f16ee25be151/ui/ozone/platform/drm/gpu/gbm_pixmap.h
[modify] https://crrev.com/46ec55a080af80c330fc5afb7770f16ee25be151/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d26bef0551356e2c16f52a091f13e197c688a14

commit 4d26bef0551356e2c16f52a091f13e197c688a14
Author: Michael Spang <spang@chromium.org>
Date: Wed Aug 01 16:37:33 2018

ozone: drm: Remove framebuffer support from DrmBuffer

This is not used anywhere except in tests, so move it to the test code.
There's probably more to be done here; the test should probably mock GBM
instead of mocking dumb buffers, which have been completely removed
everywhere else.

Bug:  869206 

Change-Id: I7900956d617d1341d222f0568516ae5027f6a9eb
Reviewed-on: https://chromium-review.googlesource.com/1155921
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579833}
[modify] https://crrev.com/4d26bef0551356e2c16f52a091f13e197c688a14/ui/ozone/platform/drm/gpu/drm_buffer.cc
[modify] https://crrev.com/4d26bef0551356e2c16f52a091f13e197c688a14/ui/ozone/platform/drm/gpu/drm_buffer.h
[modify] https://crrev.com/4d26bef0551356e2c16f52a091f13e197c688a14/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/4d26bef0551356e2c16f52a091f13e197c688a14/ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c

commit 6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c
Author: Michael Spang <spang@chromium.org>
Date: Wed Aug 01 19:11:14 2018

ozone: drm: Merge GbmDevice and GbmDeviceLinux

Currently GbmDevice is-a DrmDevice is-a GbmDeviceLinux. Instead, put a
GbmDevice inside DrmDevice. This also removes a bunch of unnecessary
casts.

Bug:  869206 

Change-Id: If7ea97f495081ebf4d05f44af2bd78c3357e23da
Reviewed-on: https://chromium-review.googlesource.com/1157254
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579887}
[modify] https://crrev.com/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c/ui/ozone/common/linux/BUILD.gn
[rename] https://crrev.com/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c/ui/ozone/common/linux/gbm_device.cc
[add] https://crrev.com/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c/ui/ozone/common/linux/gbm_device.h
[delete] https://crrev.com/1e910c7f7397ace03f42e1e39663de5ec93a9a58/ui/ozone/common/linux/gbm_device_linux.h
[modify] https://crrev.com/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c/ui/ozone/platform/drm/gpu/drm_device.cc
[modify] https://crrev.com/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c/ui/ozone/platform/drm/gpu/drm_device.h
[modify] https://crrev.com/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c/ui/ozone/platform/drm/gpu/drm_thread.cc
[delete] https://crrev.com/1e910c7f7397ace03f42e1e39663de5ec93a9a58/ui/ozone/platform/drm/gpu/gbm_device.cc
[delete] https://crrev.com/1e910c7f7397ace03f42e1e39663de5ec93a9a58/ui/ozone/platform/drm/gpu/gbm_device.h
[modify] https://crrev.com/6d378be6a6256fc23e9b8e6637a3b31ae0ccbf8c/ui/ozone/platform/drm/gpu/gbm_pixmap.h
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e

commit 20fccf32b6f9a1b5afd410407bebf72f4eca2b3e
Author: Michael Spang <spang@chromium.org>
Date: Fri Aug 03 22:13:10 2018

ozone: drm: Allow overriding GbmDevice & GbmBuffer in tests

Make these polymorphic types so that we can provide a fake implementation
of libgbm for test purposes.

Bug:  869206 
Test: ozone_unittests
Change-Id: I773cdac62bade798fbcddac54a2d5557ce1da8ce
Reviewed-on: https://chromium-review.googlesource.com/1162655
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580669}
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/common/linux/BUILD.gn
[delete] https://crrev.com/e9d7585854044bf36097599265b7d53bcce6dd95/ui/ozone/common/linux/gbm_buffer.cc
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/common/linux/gbm_buffer.h
[delete] https://crrev.com/e9d7585854044bf36097599265b7d53bcce6dd95/ui/ozone/common/linux/gbm_device.cc
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/common/linux/gbm_device.h
[add] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/common/linux/gbm_wrapper.cc
[add] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/common/linux/gbm_wrapper.h
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/platform/drm/gpu/drm_device.cc
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/platform/drm/gpu/drm_device.h
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/platform/drm/gpu/drm_device_generator.cc
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/platform/drm/gpu/drm_device_generator.h
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/platform/drm/gpu/gbm_pixmap.cc
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
[modify] https://crrev.com/20fccf32b6f9a1b5afd410407bebf72f4eca2b3e/ui/ozone/platform/drm/gpu/mock_drm_device.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df7cd3243c80a4bce1412822ac9148a40ffbc86d

commit df7cd3243c80a4bce1412822ac9148a40ffbc86d
Author: Michael Spang <spang@chromium.org>
Date: Tue Aug 07 20:17:09 2018

ozone: drm: Replace DrmFramebufferGenerator with fake GbmDevice

Instead of providing an object that creates fake framebuffers in tests,
create fake GbmBuffers and import them into the fake DrmDevice.

Bug:  869206 
Test: ozone_unittests
Change-Id: Ib00eb4befeda0ffd9299499b1f451036fa1aa2bb
Reviewed-on: https://chromium-review.googlesource.com/1162656
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581328}
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_framebuffer.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_framebuffer.h
[delete] https://crrev.com/f4fd7516f718593e4a113db17620e06a21ecdb2c/ui/ozone/platform/drm/gpu/drm_framebuffer_generator.h
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_overlay_validator.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_overlay_validator.h
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_window.h
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/drm_window_unittest.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/mock_drm_device.h
[delete] https://crrev.com/f4fd7516f718593e4a113db17620e06a21ecdb2c/ui/ozone/platform/drm/gpu/mock_drm_framebuffer_generator.cc
[delete] https://crrev.com/f4fd7516f718593e4a113db17620e06a21ecdb2c/ui/ozone/platform/drm/gpu/mock_drm_framebuffer_generator.h
[delete] https://crrev.com/f4fd7516f718593e4a113db17620e06a21ecdb2c/ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.cc
[delete] https://crrev.com/f4fd7516f718593e4a113db17620e06a21ecdb2c/ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.h
[add] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/mock_gbm_device.cc
[add] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/mock_gbm_device.h
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/screen_manager.cc
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/screen_manager.h
[modify] https://crrev.com/df7cd3243c80a4bce1412822ac9148a40ffbc86d/ui/ozone/platform/drm/gpu/screen_manager_unittest.cc

Comment 16 by spang@chromium.org, Aug 7

Status: Fixed (was: Untriaged)
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df29ae0d52a07f6bc80b344cef8a5a2358fc37f

commit 1df29ae0d52a07f6bc80b344cef8a5a2358fc37f
Author: Maksim Sisov <msisov@igalia.com>
Date: Tue Aug 14 09:47:05 2018

Roll third_party/minigbm 3cb5bba..ff1ecaf

$ git log --oneline 3cb5bbacc5c8a79105c868875222696f6b9d8296...ff1ecaf1014df4cb9ca36c5a270647a9934aaa99
ff1ecaf minigbm: fixup! align minigbm functions names with upstream libgbm
79205a5 minigbm: align minigbm functions names with upstream libgbm
faeb009 minigbm: Opening new fd for dri backend
a047d41 minigbm: increment ref count in drv_bo_import
dc8554f minigbm: amdgpu: align the stride to 256
1805a9b msm: allow allocation of NV12 dumb buffers
dea0ccb minigbm: Add BO_USE_HW_VIDEO_DECODER to supported flags
a8a3895 minigbm: close bo handle in bo destroy
293d9e3 minigbm: DRM_FORMAT_BGR888 for amdgpu
9924776 minigbm: Build fix for arm64
abe44f6 minigbm: add support for BG24
6bd7885 minigbm: run clang-format

Bug: 820047,  869206 
Change-Id: I512b35c7821fd3221a97592006de5279b414dd01
Reviewed-on: https://chromium-review.googlesource.com/1169821
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582875}
[modify] https://crrev.com/1df29ae0d52a07f6bc80b344cef8a5a2358fc37f/DEPS
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/834ebf3263bb6ba2c960bba80df15ddef6128bc1

commit 834ebf3263bb6ba2c960bba80df15ddef6128bc1
Author: Michael Spang <spang@chromium.org>
Date: Thu Aug 16 20:21:50 2018

ozone: drm: Replace DrmFramebufferGenerator with fake GbmDevice (reland)

Instead of providing an object that creates fake framebuffers in tests,
create fake GbmBuffers and import them into the fake DrmDevice.

Reland: Fixup empty modifiers case for modeset buffers by moving it into
GbmDevice.

Bug:  869206 
Test: ozone_unittests
Change-Id: I2ba134a7e1556a4d177e6e9aaa5265f0c7f6e9b7
Reviewed-on: https://chromium-review.googlesource.com/1178308
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583792}
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/common/linux/gbm_wrapper.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/BUILD.gn
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_framebuffer.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_framebuffer.h
[delete] https://crrev.com/211fda6e94cc110fb6759d263090e2b0a5a9a780/ui/ozone/platform/drm/gpu/drm_framebuffer_generator.h
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_overlay_plane.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_overlay_plane.h
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_overlay_validator.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_overlay_validator.h
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_thread.h
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_window.h
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/drm_window_unittest.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/mock_drm_device.h
[delete] https://crrev.com/211fda6e94cc110fb6759d263090e2b0a5a9a780/ui/ozone/platform/drm/gpu/mock_drm_framebuffer_generator.cc
[delete] https://crrev.com/211fda6e94cc110fb6759d263090e2b0a5a9a780/ui/ozone/platform/drm/gpu/mock_drm_framebuffer_generator.h
[delete] https://crrev.com/211fda6e94cc110fb6759d263090e2b0a5a9a780/ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.cc
[delete] https://crrev.com/211fda6e94cc110fb6759d263090e2b0a5a9a780/ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.h
[add] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/mock_gbm_device.cc
[add] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/mock_gbm_device.h
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/screen_manager.cc
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/screen_manager.h
[modify] https://crrev.com/834ebf3263bb6ba2c960bba80df15ddef6128bc1/ui/ozone/platform/drm/gpu/screen_manager_unittest.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dc2f03d8086a9b60136c3585abb83aca356a676

commit 9dc2f03d8086a9b60136c3585abb83aca356a676
Author: Maksim Sisov <msisov@igalia.com>
Date: Fri Sep 07 09:36:33 2018

[ozone/common] Make gbm_wrapper to be compiled with system libgbm

This patch makes use of new minigbm APi names, which are aligned with
Linux libgbm.

Also, it defines certain definitions, which are different between
libgbm and minigbm.

What is more, it adds USING_MINIGBM for internal usage to be able
to distinguish between system linux gbm and minigbm.

Last but not least, drmPrimeHandleToFd is used in case of linux
system libgbm in order to be able to get mappable fds per each
plane, which is neede to add GpuMemoryBuffers support.

Bug:  869206 , 578890, 820047
Change-Id: I0a743aef1c8bad2bb5792a58ab29abec45ea4585
Reviewed-on: https://chromium-review.googlesource.com/1158234
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589475}
[modify] https://crrev.com/9dc2f03d8086a9b60136c3585abb83aca356a676/ui/ozone/common/linux/gbm_wrapper.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/816f0e1e5c15d7fce9389a428cbd49bbdf158501

commit 816f0e1e5c15d7fce9389a428cbd49bbdf158501
Author: Ryo Hashimoto <hashimoto@chromium.org>
Date: Wed Sep 19 04:46:16 2018

Revert "[ozone/common] Make gbm_wrapper to be compiled with system libgbm"

This reverts commit 9dc2f03d8086a9b60136c3585abb83aca356a676.

Reason for revert: causes crash loop on grunt

Original change's description:
> [ozone/common] Make gbm_wrapper to be compiled with system libgbm
> 
> This patch makes use of new minigbm APi names, which are aligned with
> Linux libgbm.
> 
> Also, it defines certain definitions, which are different between
> libgbm and minigbm.
> 
> What is more, it adds USING_MINIGBM for internal usage to be able
> to distinguish between system linux gbm and minigbm.
> 
> Last but not least, drmPrimeHandleToFd is used in case of linux
> system libgbm in order to be able to get mappable fds per each
> plane, which is neede to add GpuMemoryBuffers support.
> 
> Bug:  869206 , 578890, 820047
> Change-Id: I0a743aef1c8bad2bb5792a58ab29abec45ea4585
> Reviewed-on: https://chromium-review.googlesource.com/1158234
> Commit-Queue: Maksim Sisov <msisov@igalia.com>
> Reviewed-by: Michael Spang <spang@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589475}

TBR=rjkroege@chromium.org,spang@chromium.org,msisov@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  869206 , 578890, 820047
Change-Id: Idd0f9e4aa584bc1e353d3947cef12e4ee8839385
Reviewed-on: https://chromium-review.googlesource.com/1232881
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592321}
[modify] https://crrev.com/816f0e1e5c15d7fce9389a428cbd49bbdf158501/ui/ozone/common/linux/gbm_wrapper.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f99be2213ca6958f558add3eaf4494101a4c1821

commit f99be2213ca6958f558add3eaf4494101a4c1821
Author: Maksim Sisov <msisov@igalia.com>
Date: Tue Oct 16 06:50:03 2018

[ozone/common] Make planar import work with 0x5505 and 0x5504.

This is first step to migrate minigbm to use
GBM_BO_IMPORT_FD_MODIFIER instead of GBM_BO_IMPORT_FD_PLANAR.

Ones ChromeOS will start using the newest chrome, we can
finally add GBM_BO_IMPORT_FD_MODIFIER 0x5504 to minigbm and
get rid of GBM_BO_IMPORT_FD_PLANAR.

See comment from Tomasz in https://crrev.com/c/1273455

Bug:  869206 , 578890, 820047
Change-Id: Ibac5c0c874c523e845675ff944561d3e2a3ec530
Reviewed-on: https://chromium-review.googlesource.com/c/1278400
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599893}
[modify] https://crrev.com/f99be2213ca6958f558add3eaf4494101a4c1821/ui/ozone/common/linux/gbm_wrapper.cc
►

Sign in to add a comment