New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 869185 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Make "Warn Before Quitting" default-on for Mac

Project Member Reported by thomasanderson@chromium.org, Jul 30

Issue description

There's a general consensus that the "hold to quit" feature should be default-on for Mac.
 
image.png
98.5 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55484f7550ce62889190e5e51bc678bc8ef0f798

commit 55484f7550ce62889190e5e51bc678bc8ef0f798
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Jul 31 17:15:27 2018

Enable confirm-to-quit on Mac by default

BUG= 869185 

Change-Id: I9785566ea733c97da198251f752b33a3a9a31e57
Reviewed-on: https://chromium-review.googlesource.com/1155811
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579445}
[modify] https://crrev.com/55484f7550ce62889190e5e51bc678bc8ef0f798/chrome/browser/ui/confirm_quit.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-70 TE-Verified-70.0.3510.0
Able to reproduce the issue on Mac 10.12.6 on build without fix #70.0.3507.0.

Verified the fix on Mac 10.12.6, as per comment#0 on latest chrome version #70.0.3510.0.
Attaching screen shots for reference.
Observed that "Warn Before Quitting" is  default
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!
70.0.3507.0.png
173 KB View Download
70.0.3510.0.png
178 KB View Download
 Issue 892222  has been merged into this issue.
FYI: User-Feedback regarding this change in  issue 896433 .

Sign in to add a comment