New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 869182 link

Starred by 1 user
Status: Fixed
Owner:
petewil@chromium.org
Closed: Aug 1
Cc:
█ romax@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline Page Saving fails when destination directory is not present

Project Member Reported by petewil@chromium.org, Jul 30 
Looking at metrics of the offline pages sharing feature, we discover that a percentage of users has offline page saving fail.

This happens because when we ask Android what directory to use for downloaded files, the directory does not exist in some cases.

The fix for this is to create the directory if it does not already exist before copying the downloaded page into it.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01f42f90cbe9fcf2b958ff4178e66ae969113194

commit 01f42f90cbe9fcf2b958ff4178e66ae969113194
Author: Pete Williamson <petewil@chromium.org>
Date: Wed Aug 01 00:31:31 2018

Create the download directory if it doesn't exist before publishing.

OfflinePages are now saved to a public directory "/sdcard/Download/".
However, the saving sometimes fails when the directory doesn't exist.
This change checks for the existence of the directory, and creates
it before the publish step.

Bug:  869182 

Change-Id: I3e0105c5ddb2df7a5fa9b57a5bf3ba7478af3b09
Reviewed-on: https://chromium-review.googlesource.com/1150406
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579638}
[modify] https://crrev.com/01f42f90cbe9fcf2b958ff4178e66ae969113194/components/offline_pages/core/offline_page_archiver.cc
[modify] https://crrev.com/01f42f90cbe9fcf2b958ff4178e66ae969113194/tools/metrics/histograms/histograms.xml

Comment 2 by petewil@chromium.org, Aug 1

Labels: Merge-Request-69
This fixes a bug with offline sharing that users are seeing now in M67, it would be great to get the fix into M69.

Comment 3 by petewil@chromium.org, Aug 1

Status: Fixed (was: Started)

Comment 4 by petewil@chromium.org, Aug 1

Cc: romax@chromium.org

Comment 5 by gov...@chromium.org, Aug 1 

Pls apply appropriate OSs label.

Comment 6 by romax@chromium.org, Aug 1

Labels: OS-Android
sorry for the inconvenience, this fix is for Android
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 2

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 2

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed4e2a256c7269ce58ea713921e8dd86066d6462

commit ed4e2a256c7269ce58ea713921e8dd86066d6462
Author: Pete Williamson <petewil@chromium.org>
Date: Thu Aug 02 01:28:14 2018

Create the download directory if it doesn't exist before publishing.

OfflinePages are now saved to a public directory "/sdcard/Download/".
However, the saving sometimes fails when the directory doesn't exist.
This change checks for the existence of the directory, and creates
it before the publish step.

Bug:  869182 

Change-Id: I3e0105c5ddb2df7a5fa9b57a5bf3ba7478af3b09
Reviewed-on: https://chromium-review.googlesource.com/1150406
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579638}(cherry picked from commit 01f42f90cbe9fcf2b958ff4178e66ae969113194)
Reviewed-on: https://chromium-review.googlesource.com/1159781
Cr-Commit-Position: refs/branch-heads/3497@{#328}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/ed4e2a256c7269ce58ea713921e8dd86066d6462/components/offline_pages/core/offline_page_archiver.cc
[modify] https://crrev.com/ed4e2a256c7269ce58ea713921e8dd86066d6462/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment