New issue
Advanced search Search tips

Issue 869176 link

Starred by 1 user
Status: WontFix
Owner:
olivierrobin@chromium.org
Closed: Aug 23
Cc:
marq@chromium.org
kariahda@chromium.org
justincohen@chromium.org
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Re-enable QRScannerViewController tests on iOS 10 iPad.

Project Member Reported by michaeldo@chromium.org, Jul 30 
These tests are failing consistently in ios_chrome_ui_egtests QRScannerViewControllerTestCase

testReceivingQRScannerURLResultAndEditingTheURL
testReceivingQRScannerSearchQueryResultAndEditingTheQuery
testDialogDismissedIfCameraBecomesAvailable
testTorchButtonIsResetWhenQRScannerIsReopened

Note that testReceivingQRScannerURLResultAndEditingTheURL and testReceivingQRScannerSearchQueryResultAndEditingTheQuery are already disabled on iOS 11 iPad, so there is now no tablet coverage with these also disabled on iOS 10.

See: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-device-x64/builds/12565/steps/ios_chrome_ui_egtests%20%28iPad%20Air%20iOS%2010.3.3%29%20on%20iOS-10.3.3

Comment 1 by michaeldo@chromium.org, Jul 30

Cc: olivierrobin@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94b94be19fba32eedb72590a411fb507e473c5b5

commit 94b94be19fba32eedb72590a411fb507e473c5b5
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Tue Jul 31 00:58:04 2018

Disable failing QRScanner EarlGrey tests for iOS 10 iPad.

TBR=eugenebut@google.com

Bug:  869176 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9155f518e23fd6c739e2bd13c16eceff1d9f04b2
Reviewed-on: https://chromium-review.googlesource.com/1155793
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579268}
[modify] https://crrev.com/94b94be19fba32eedb72590a411fb507e473c5b5/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1185511fbba9f8c4a74515fc7d616e1fb1e33623

commit 1185511fbba9f8c4a74515fc7d616e1fb1e33623
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Tue Jul 31 18:59:36 2018

Disable QRScanner EarlGrey tests on device.

The tests were mistakenly also disabled for simulator in
crrev.com/c/1155793.

TBR=marq@chromium.org

Bug:  869176 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I794468b78f4259ed10e230074c54a5ed0552e1f4
Reviewed-on: https://chromium-review.googlesource.com/1157109
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579506}
[modify] https://crrev.com/1185511fbba9f8c4a74515fc7d616e1fb1e33623/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm

Comment 4 by sczs@chromium.org, Aug 1

Cc: -olivierrobin@chromium.org kariahda@chromium.org
Owner: olivierrobin@chromium.org
Status: Assigned (was: Untriaged)
Assigning to olivierrobin@ since he's the sole directory Owner.

+kariahda@ since this was marked as M70 blocker

Comment 5 by michaeldo@chromium.org, Aug 1 

Olivier is OOO, but also I think the RBB was a mistake. This is only for on device tests, not simulator.

I'll let kariahda@ confirm that this is still true of our process.

Comment 6 by kariahda@chromium.org, Aug 14 

RBB should be placed on both device and simulator failures for the next branch milestone. Labels are correct.

Who would be the next best person to take a look at this?

Comment 7 by michaeldo@chromium.org, Aug 14

Cc: marq@chromium.org
+ marq@ to CC

marq@ and rohitrao@ are OWNERS of the directory one level up, so possibly one of them?

Comment 8 by olivierrobin@chromium.org, Aug 23 

I cannot reproduce the issue locally.

Comment 9 by justincohen@chromium.org, Aug 23

Status: WontFix (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a6b4910cafd88be5a971e6cbd5e10171f91524

commit 58a6b4910cafd88be5a971e6cbd5e10171f91524
Author: Justin Cohen <justincohen@google.com>
Date: Wed Nov 14 19:27:19 2018

[ios] Drop iOS10 specific code.

875528, 875528, 750185, 850814

Bug: 894099,  766951 ,  836808 , 740987,  765146 ,  826369 ,  730461 ,  869176 ,
Change-Id: I07b3ab43cff3d4d4f17349fe5eff9070fef5d437
Reviewed-on: https://chromium-review.googlesource.com/c/1335207
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608075}
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/form_input_accessory_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/drag_and_drop/drop_and_navigate_interaction_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/metrics/drag_and_drop_recorder.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/net/cookie_util_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/prerender/prerender_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/snapshots/snapshot_tab_helper.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/app_launcher/open_mail_handler_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_option_button.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_presentation_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmark_edit_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/bubble/bubble_view_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_layout.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/find_bar/find_bar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/fullscreen/fullscreen_system_notification_observer.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/cells/page_info_item.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/cells/payments_selector_edit_item.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/payments/payment_request_picker_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/print/print_controller_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_transition_handler.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/tabs/tab_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/primary_toolbar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/secondary_toolbar_view.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/util/uikit_ui_util.h
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/ui/util/uikit_ui_util.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/BUILD.gn
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/constraints_ui_util.h
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/chrome/common/ui_util/constraints_ui_util.mm
[delete] https://crrev.com/d8af30684b21a6141ab4b4e163eb300f6cb1c4af/ios/chrome/common/ui_util/constraints_ui_util_unittest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/showcase/payments/sc_payments_picker_egtest.mm
[modify] https://crrev.com/58a6b4910cafd88be5a971e6cbd5e10171f91524/ios/showcase/test/showcase_eg_utils.mm
►

Sign in to add a comment