[Media Router] DIAL-discovered Cast device shows up twice on list |
||||||||
Issue descriptionThis is a regression seen with Android TV devices. Chrome: M69 (MR 69) Platforms: Mac, Win Repro steps: 1. Go to a youtube video. 2. Click the in-player or toolbar Cast icon. Expected: one entry in the dialog for the ATV Actual: two entries, one with the Cast icon, and one with the DIAL icon. The cause is a recent update in ATV caused its description data to change, and it no longer matches the list of hardcoded Cast device model names. There are 2 possible workarounds: 1. Deduping by sink id needs to strip the cast:/dial: prefix so there aren't duplicate sinks in the UI 2. block DIAL app queries to devices that are Cast-compatible. Separately, Android TV shouldn't advertise itself as compatible with YouTube DIAL app as DIAL launch does not work. mfoltz@ to start a follow-up bug/thread on this.
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f04a5b6d079bce23fa6f11e214dbbfd55cf15fd5 commit f04a5b6d079bce23fa6f11e214dbbfd55cf15fd5 Author: Derek Cheng <imcheng@chromium.org> Date: Tue Jul 31 18:22:54 2018 [MediaRouter] std::move() on MediaSinkInternal in MediaSinkServiceBase Follow-up to http://crrev.com/579256 Bug: 869112 Change-Id: Ie8d560bf0a01fa811dfa5529269a9756ae81447b Reviewed-on: https://chromium-review.googlesource.com/1156996 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579484} [modify] https://crrev.com/f04a5b6d079bce23fa6f11e214dbbfd55cf15fd5/chrome/common/media_router/discovery/media_sink_service_base.cc
,
Aug 7
This should be fixed in dev and canary now.
,
Aug 7
,
Aug 7
Request merge for patch in c#1.
,
Aug 7
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 7
,
Aug 7
Could you pls justify the merge to M69? How safe it is and why it is needed?
,
Aug 7
The merge is needed because Android TV (and possibly other types of Cast-enabled devices) shows up on the Media Router device list twice. One of which won't work when the user selects it. This results in a not so good user experience. I've verified the fix, dbbrooks@ is also verifying it on canary/dev right now.
,
Aug 7
Is it M69 regression?
,
Aug 7
Verified fixed in M70 70.0.3515.0
,
Aug 7
It isn't a M69 regression per se, but this is a bug that is exposed by a change in the ATV receiver behavior.
,
Aug 7
Rejecting merge to M69 based on offline chat with imcheng@.
,
Aug 7
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 31