New issue
Advanced search Search tips

Issue 869046 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 0
Type: Bug



Sign in to add a comment

Merge request for 1145627 to M69

Project Member Reported by georgesak@chromium.org, Jul 30

Issue description

This fixes a bug in our Mac OS implementation.

It's very low risk.
 
Labels: -Merge-Request-69 Merge-Approved-69
Approving merge to M69 branch 3497, pls merge ASAP. Thank you.
Status: Fixed (was: Started)
Merged here : https://chromium-review.googlesource.com/c/chromium/src/+/1145627

Thanks.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecc739b864d0a37661ce18e4e37c5677b4d9c79c

commit ecc739b864d0a37661ce18e4e37c5677b4d9c79c
Author: Georges Khalil <georgesak@chromium.org>
Date: Tue Jul 31 01:02:11 2018

Change Mac OS token location and file name.

This CL has 2 changes:
- Change location to Google Policy/Enrollment
- Derive filename from client ID (in case the home directory is mounted remotely)

Change-Id: I5b3acafd20119f79deef24fb44e3e0514c693311
Reviewed-on: https://chromium-review.googlesource.com/1145627
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577410}(cherry picked from commit 43be30f47adc41bcfe939fc0cd03f0479dc0efb8)
Bug:  869046 
Reviewed-on: https://chromium-review.googlesource.com/1155347
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#257}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/ecc739b864d0a37661ce18e4e37c5677b4d9c79c/chrome/browser/policy/browser_dm_token_storage.h
[modify] https://crrev.com/ecc739b864d0a37661ce18e4e37c5677b4d9c79c/chrome/browser/policy/browser_dm_token_storage_mac.mm
[modify] https://crrev.com/ecc739b864d0a37661ce18e4e37c5677b4d9c79c/chrome/browser/policy/browser_dm_token_storage_mac_unittest.cc

Sign in to add a comment