[PIP] Controls appear when switching to Chrome profile with PiP open |
|||
Issue descriptionChrome Version: 70.0.3507.0 OS: Mac 10.13.6 What steps will reproduce the problem? (1) Open two Chrome profiles on the same browser channel. (2) Enter PiP on first profile. (3) Go to second profile browser window. (4) Go to first profile browser window. Observe PiP window controls appear. What is the expected result? Controls do not appear What happens instead? Controls appear. Probably happens because the PiP window becomes in focus.
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9609aa3aec3e858dbf7d205b1a62743d6ff0584 commit e9609aa3aec3e858dbf7d205b1a62743d6ff0584 Author: Jennifer Apacible <apacible@chromium.org> Date: Tue Aug 28 20:31:20 2018 [Picture in Picture] Do not show controls when window is initially focused. Currently, almost any way a window is initially focused will show the controls. This includes: - Focusing a browser window. - Focusing the Picture-in-Picture window. - Switching between Chrome profiles to a profile with an active Picture- in-Picture window. This causes the controls to appear a bit aggressively, even when the user hasn't explicitly interacted with the window. This change will fix some commented behavior, which was not supported: "...tabbing or touch gesture will show the controls." Any keyboard interaction will show the controls. The Tab key needed to be specifically handled. This removes some logic for a special case on when the window is initially opened. This was also tested with VoiceOver on Mac. Bug: 869042 Change-Id: Id05f916a4857afaba18453db1f0b220be78657ca Reviewed-on: https://chromium-review.googlesource.com/1191820 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#586835} [modify] https://crrev.com/e9609aa3aec3e858dbf7d205b1a62743d6ff0584/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/e9609aa3aec3e858dbf7d205b1a62743d6ff0584/chrome/browser/ui/views/overlay/overlay_window_views.h
,
Aug 29
,
Aug 30
Tried to reproduce the issue on Mac OS 10.13.3 on the reported version 70.0.3507.0 and unable to reproduce the issue by following the below steps. 1. Launched Chrome and the flag enable-picture-in-picture is enabled in chrome://flags. 2. Navigated to https://japacible.github.io/sandbox/index.html and entered PIP on first profile. 3. Navigated to the second profile window and then went back to first profile window, could observe that the Controls do not appear on the PIP window. Attached is the screen cast for reference. apacible@ Request you to check and confirm if anything is missed from our end in reproducing the issue and help us in verifying the fix on the latest M-70 build. Thanks.. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mlamouri@chromium.org
, Aug 2