browser crash on OnFocusTabScoreAdjustmentTimeout |
|||||||
Issue descriptionAfter syncing to ToT, the browser process starts crashing on resource_coordinator::TabManagerDelegate::OnFocusTabScoreAdjustmentTimeout(). The crash stack looks like: [94350:94350:0730/101716.570840:FATAL:thread_restrictions.cc(29)] Check failed: !g_blocking_disallowed.Get().Get(). Function marked as blocking was called from a scope that disallows blocking! If this task is running inside the TaskScheduler, it needs to have MayBlock() in its TaskTraits. Otherwise, consider making this blocking work asynchronous or, as a last resort, you may use ScopedAllowBlocking (see its documentation for best practices). #0 0x7fe22d7441dd base::debug::StackTrace::StackTrace() #1 0x7fe22d46773c base::debug::StackTrace::StackTrace() #2 0x7fe22d4d0eed logging::LogMessage::~LogMessage() #3 0x7fe22d68d64b base::AssertBlockingAllowed() #4 0x7fe22d751644 base::PathExists() #5 0x7fe22d57f872 base::AdjustOOMScore() #6 0x564558faa124 resource_coordinator::TabManagerDelegate::OnFocusTabScoreAdjustmentTimeout() #7 0x564555a7848d _ZN4base8internal13FunctorTraitsIMN18OAuth2TokenService7FetcherEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #8 0x564555a78404 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN18OAuth2TokenService7FetcherEFvvEJPS5_EEEvOT_DpOT0_ #9 0x564555a783b5 _ZN4base8internal7InvokerINS0_9BindStateIMN18OAuth2TokenService7FetcherEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer _sequenceImJXspT1_EEEE #10 0x564555a78359 _ZN4base8internal7InvokerINS0_9BindStateIMN18OAuth2TokenService7FetcherEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #11 0x7fe22d418fbe _ZNO4base12OnceCallbackIFvvEE3RunEv #12 0x7fe22d6943fb base::OneShotTimer::RunUserTask() #13 0x7fe22d693f73 base::internal::TimerBase::RunScheduledTask() #14 0x7fe22d694b29 base::internal::BaseTimerTaskInternal::Run() #15 0x7fe22d4ac53d _ZN4base8internal13FunctorTraitsIMNS_19ImportantFileWriterEFvvEvE6InvokeIS4_PS2_JEEEvT_OT0_DpOT1_ #16 0x7fe22d4ac4b4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMNS_19ImportantFileWriterEFvvEJPS4_EEEvOT_DpOT0_ #17 0x7fe22d4ac465 _ZN4base8internal7InvokerINS0_9BindStateIMNS_19ImportantFileWriterEFvvEJNS0_17UnretainedWrapperIS3_EEEEEFvvEE7RunImplIRKS5_RKNSt3__15tupleIJS7_EEEJLm0EEEEvOT_OT0_NSE_16integer _sequenceImJXspT1_EEEE #18 0x7fe22d59df79 _ZN4base8internal7InvokerINS0_9BindStateIMNS_7RunLoopEFvvEJNS0_17UnretainedWrapperIS3_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #19 0x7fe22d418fbe _ZNO4base12OnceCallbackIFvvEE3RunEv #20 0x7fe22d468aca base::debug::TaskAnnotator::RunTask() #21 0x7fe22d4f7ae0 base::MessageLoop::RunTask() #22 0x7fe22d4f7d25 base::MessageLoop::DeferOrRunPendingTask() #23 0x7fe22d4f84a5 base::MessageLoop::DoDelayedWork() #24 0x7fe22d787b72 base::MessagePumpLibevent::Run() #25 0x7fe22d4f73ee base::MessageLoop::Run() #26 0x7fe22d59c662 base::RunLoop::Run() #27 0x564558826e7a ChromeBrowserMainParts::MainMessageLoopRun() #28 0x7fe226f64dfa content::BrowserMainLoop::RunMainMessageLoopParts() #29 0x7fe226f6bd50 content::BrowserMainRunnerImpl::Run() #30 0x7fe226f584b0 content::BrowserMain() #31 0x7fe228d15fb4 content::RunBrowserProcessMain() #32 0x7fe228d187ba content::ContentMainRunnerImpl::Run() #33 0x7fe228d0d03c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #34 0x7fe22ef02971 service_manager::Main() #35 0x7fe228d13195 content::ContentMain() #36 0x56455593b246 ChromeMain #37 0x56455593b152 main #38 0x7fe2058832b1 __libc_start_main #39 0x56455593b02a _start
,
Jul 30
,
Jul 30
mukai, please help to lgtm http://crrev.com/c/1155327
,
Jul 30
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e64d2d620942faf985763c6c25f27448c84cea9d commit e64d2d620942faf985763c6c25f27448c84cea9d Author: Vovo Yang <vovoy@chromium.org> Date: Mon Jul 30 18:15:48 2018 Revert "Set oom_score_adj of chrome processes directly" This reverts commit 0f6c2c59656fb462932cf57262e8c1b2f9c3b46f. Reason for revert: crash on OnFocusTabScoreAdjustmentTimeout Bug: 869037 Original change's description: > Set oom_score_adj of chrome processes directly > > Setting oom_score_adj directly is faster and doesn't have to involve > debugd when ARC++ is disabled. > > Bug: 868249 > Change-Id: Ifeda6cd1d393c85f373928aafadd4ec3d3941a92 > Reviewed-on: https://chromium-review.googlesource.com/1152751 > Reviewed-by: Cheng-Yu Lee <cylee@chromium.org> > Commit-Queue: Vovo Yang <vovoy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578987} TBR=cylee@chromium.org,vovoy@chromium.org Change-Id: Iafc37f22743479ba558fcc520bd24e7a30bcc693 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868249 Reviewed-on: https://chromium-review.googlesource.com/1155327 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579090} [modify] https://crrev.com/e64d2d620942faf985763c6c25f27448c84cea9d/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
,
Aug 1
If it's P0, it should block a release. If you do not think this should block a release, change the label and the priority.
,
Aug 2
,
Aug 3
,
Aug 3
I believe the reported bug was fixed thanks to the revert. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mukai@chromium.org
, Jul 30Labels: -Pri-1 Pri-0
Owner: vovoy@chromium.org
Status: Assigned (was: Available)